Code review comment for lp:~gz/bzr/2.3_unprintable_retrywithnewpacks

Revision history for this message
Vincent Ladeuil (vila) wrote :

Safe and obvious indeed, green light to merge in 2.3 and up to trunk

Just one question:

26 + '{context} {exc value}', str(error))

is error not an exception or is it safe to call str() here ? If the later, I'll warmly welcome some idiot-proof guide on when that's the case ;)

review: Approve

« Back to merge proposal