Merge lp:~gz/bzr-explorer/repo_view_non_ascii_branch_open_777860 into lp:bzr-explorer
Proposed by
Martin Packman
Status: | Merged |
---|---|
Approved by: | Alexander Belchenko |
Approved revision: | 504 |
Merged at revision: | 503 |
Proposed branch: | lp:~gz/bzr-explorer/repo_view_non_ascii_branch_open_777860 |
Merge into: | lp:bzr-explorer |
Diff against target: |
28 lines (+6/-1) 2 files modified
NEWS (+5/-0) lib/view_repository.py (+1/-1) |
To merge this branch: | bzr merge lp:~gz/bzr-explorer/repo_view_non_ascii_branch_open_777860 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexander Belchenko | Approve | ||
Review via email: mp+60090@code.launchpad.net |
Description of the change
Opening branches with non-ascii names works in general, but from the repository view you get an error about invalid urls. Seems the code is a little confused about what the path is. Both osutils and urlutils are used in the file. Simply escaping the relpath (which will always be one directory as far as I can see, so we don't need to worry about slashes) in _get_abspath appears to resolve the issue at least.
I've tested this manually, and would like to add an automated test. I don't see anything likely in the tests folder to base one off however.
To post a comment you must log in.
Many thanks for your quick patch!
Re tests: testing GUI is not very easy, at least I haven't found my way into these lands yet.