Merge lp:~gz/brz/lint_E241_E251 into lp:brz

Proposed by Martin Packman
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~gz/brz/lint_E241_E251
Merge into: lp:brz
Diff against target: 131 lines (+29/-38)
3 files modified
setup.cfg (+0/-2)
setup.py (+25/-24)
tools/win32/bootstrap.py (+4/-12)
To merge this branch: bzr merge lp:~gz/brz/lint_E241_E251
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+358966@code.launchpad.net

Commit message

Fix whitespace lint E241 and E251

Description of the change

Fix whitespace lint E241 and E251

Includes editing the third-party bootstrap script which should maybe
just go, but can deal with that later.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.cfg'
--- setup.cfg 2018-11-18 12:41:12 +0000
+++ setup.cfg 2018-11-18 19:11:39 +0000
@@ -6,8 +6,6 @@
6 D6 D
7 I7 I
8 E1238 E123
9 E241
10 E251
11 E2619 E261
12 E26510 E265
13 E26611 E266
1412
=== modified file 'setup.py'
--- setup.py 2018-11-17 16:53:10 +0000
+++ setup.py 2018-11-18 19:11:39 +0000
@@ -32,13 +32,13 @@
32# META INFORMATION FOR SETUP32# META INFORMATION FOR SETUP
33# see http://docs.python.org/dist/meta-data.html33# see http://docs.python.org/dist/meta-data.html
34META_INFO = {34META_INFO = {
35 'name': 'breezy',35 'name': 'breezy',
36 'version': breezy.__version__,36 'version': breezy.__version__,
37 'maintainer': 'Breezy Developers',37 'maintainer': 'Breezy Developers',
38 'maintainer_email': 'team@breezy-vcs.org',38 'maintainer_email': 'team@breezy-vcs.org',
39 'url': 'https://www.breezy-vcs.org/',39 'url': 'https://www.breezy-vcs.org/',
40 'description': 'Friendly distributed version control system',40 'description': 'Friendly distributed version control system',
41 'license': 'GNU GPL v2',41 'license': 'GNU GPL v2',
42 'download_url': 'https://launchpad.net/brz/+download',42 'download_url': 'https://launchpad.net/brz/+download',
43 'long_description': get_long_description(),43 'long_description': get_long_description(),
44 'classifiers': [44 'classifiers': [
@@ -382,9 +382,9 @@
382 # tbzrcache executables - a "console" version for debugging and a382 # tbzrcache executables - a "console" version for debugging and a
383 # GUI version that is generally used.383 # GUI version that is generally used.
384 tbzrcache = dict(384 tbzrcache = dict(
385 script = os.path.join(tbzr_root, "scripts", "tbzrcache.py"),385 script=os.path.join(tbzr_root, "scripts", "tbzrcache.py"),
386 icon_resources = icon_resources,386 icon_resources=icon_resources,
387 other_resources = other_resources,387 other_resources=other_resources,
388 )388 )
389 console_targets.append(tbzrcache)389 console_targets.append(tbzrcache)
390390
@@ -395,9 +395,9 @@
395395
396 # ditto for the tbzrcommand tool396 # ditto for the tbzrcommand tool
397 tbzrcommand = dict(397 tbzrcommand = dict(
398 script = os.path.join(tbzr_root, "scripts", "tbzrcommand.py"),398 script=os.path.join(tbzr_root, "scripts", "tbzrcommand.py"),
399 icon_resources = icon_resources,399 icon_resources=icon_resources,
400 other_resources = other_resources,400 other_resources=other_resources,
401 )401 )
402 console_targets.append(tbzrcommand)402 console_targets.append(tbzrcommand)
403 tbzrcommandw = tbzrcommand.copy()403 tbzrcommandw = tbzrcommand.copy()
@@ -561,17 +561,18 @@
561 self.outfiles.extend([f + 'o' for f in compile_names])561 self.outfiles.extend([f + 'o' for f in compile_names])
562 # end of class install_data_with_bytecompile562 # end of class install_data_with_bytecompile
563563
564 target = py2exe.build_exe.Target(script = "brz",564 target = py2exe.build_exe.Target(
565 dest_base = "brz",565 script="brz",
566 icon_resources = [(0, 'brz.ico')],566 dest_base="brz",
567 name = META_INFO['name'],567 icon_resources=[(0, 'brz.ico')],
568 version = version_str,568 name=META_INFO['name'],
569 description = META_INFO['description'],569 version=version_str,
570 author = META_INFO['author'],570 description=META_INFO['description'],
571 copyright = "(c) Canonical Ltd, 2005-2010",571 author=META_INFO['author'],
572 company_name = "Canonical Ltd.",572 copyright="(c) Canonical Ltd, 2005-2010",
573 comments = META_INFO['description'],573 company_name="Canonical Ltd.",
574 )574 comments=META_INFO['description'],
575 )
575 gui_target = copy.copy(target)576 gui_target = copy.copy(target)
576 gui_target.dest_base = "bzrw"577 gui_target.dest_base = "bzrw"
577578
578579
=== modified file 'tools/win32/bootstrap.py'
--- tools/win32/bootstrap.py 2018-11-16 13:00:09 +0000
+++ tools/win32/bootstrap.py 2018-11-18 19:11:39 +0000
@@ -48,16 +48,13 @@
4848
49cmd = 'from setuptools.command.easy_install import main; main()'49cmd = 'from setuptools.command.easy_install import main; main()'
50ws = pkg_resources.working_set50ws = pkg_resources.working_set
51env = dict(
52 os.environ,
53 PYTHONPATH=ws.find(pkg_resources.Requirement.parse('setuptools')).location)
5154
52if is_jython:55if is_jython:
53 import subprocess56 import subprocess
5457
55 env = dict(
56 os.environ,
57 PYTHONPATH=ws.find(
58 pkg_resources.Requirement.parse('setuptools')).location
59 )
60
61 assert subprocess.Popen(58 assert subprocess.Popen(
62 [sys.executable] +59 [sys.executable] +
63 ['-c', quote(cmd), '-mqNxd', quote(tmpeggs), 'zc.buildout'],60 ['-c', quote(cmd), '-mqNxd', quote(tmpeggs), 'zc.buildout'],
@@ -66,12 +63,7 @@
66else:63else:
67 assert os.spawnle(64 assert os.spawnle(
68 os.P_WAIT, sys.executable, quote(sys.executable),65 os.P_WAIT, sys.executable, quote(sys.executable),
69 '-c', quote(cmd), '-mqNxd', quote(tmpeggs), 'zc.buildout',66 '-c', quote(cmd), '-mqNxd', quote(tmpeggs), 'zc.buildout', env,
70 dict(
71 os.environ,
72 PYTHONPATH=
73 ws.find(pkg_resources.Requirement.parse('setuptools')).location
74 ),
75 ) == 067 ) == 0
7668
77ws.add_entry(tmpeggs)69ws.add_entry(tmpeggs)

Subscribers

People subscribed via source and target branches