Code review comment for lp:~gunnarhj/indicator-datetime/days-months

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Patch looks correct, and works on my system. This will bring the datetime indicator to get translated date strings in the same language as the rest of the UI; which is the "best" we can do considering the current situation with the LC_TIME POSIX category. It will still use LC_TIME for the ordering of the bits of information and time format.

While this is a departure from the standard, and so suboptimal (doesn't fix 'date', for instance, which will still use LC_TIME to display everything), it brings us a bit closer to what users may reasonably expect -- an interface all in the same language.

review: Approve

« Back to merge proposal