Code review comment for lp:~gunchleoc/widelands/i18n-20140307

Revision history for this message
GunChleoc (gunchleoc) wrote :

> I have a question about the changes made to for example the wood gnome win
> condition.
>
> having quotes for each line makes it really inconvenient to type those texts
> (in the source). I.e.
>
> [snip]
> Why are those changes necessary?

I am adding those because semantically empty line breaks are confusing for translators, thus creating extra work for them + head scratching.

Could you please have a look at game_main_menu_save_game.cc for me? I can't get it to work like I want and I can't find the problem. Look for the comment: // TODO: This should be ngettext(" %i player" etc. with boost::format, but it refuses to work, line 140 + 180. If I use boost::format on these with proper numbering, the number isn't displayed properly.

« Back to merge proposal