Merge lp:~gunchleoc/widelands/bug-1299919 into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 6921
Proposed branch: lp:~gunchleoc/widelands/bug-1299919
Merge into: lp:widelands
Diff against target: 42 lines (+9/-16)
1 file modified
src/wui/soldierlist.cc (+9/-16)
To merge this branch: bzr merge lp:~gunchleoc/widelands/bug-1299919
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+214005@code.launchpad.net

Description of the change

Small string fix (replaced snprintf with boost::format)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/wui/soldierlist.cc'
2--- src/wui/soldierlist.cc 2014-03-05 11:59:09 +0000
3+++ src/wui/soldierlist.cc 2014-04-03 11:48:25 +0000
4@@ -20,6 +20,7 @@
5 #include "wui/soldierlist.h"
6
7 #include <boost/bind.hpp>
8+#include <boost/format.hpp>
9
10 #include "container_iterate.h"
11 #include "graphic/font.h"
12@@ -473,22 +474,14 @@
13 return;
14 }
15
16- uint32_t const hl = soldier->get_hp_level ();
17- uint32_t const mhl = soldier->get_max_hp_level ();
18- uint32_t const al = soldier->get_attack_level ();
19- uint32_t const mal = soldier->get_max_attack_level ();
20- uint32_t const dl = soldier->get_defense_level ();
21- uint32_t const mdl = soldier->get_max_defense_level();
22- uint32_t const el = soldier->get_evade_level ();
23- uint32_t const mel = soldier->get_max_evade_level ();
24-
25- char buffer[5 * 30];
26- snprintf
27- (buffer, sizeof(buffer),
28- /** TRANSLATORS: Health, Attack, Defense, Evade */
29- _("HP: %1$u/%2$u AT: %3$u/%4$u DE: %5$u/%6$u EV: %7$u/%8$u"),
30- hl, mhl, al, mal, dl, mdl, el, mel);
31- m_infotext.set_text(buffer);
32+ m_infotext.set_text(
33+ (boost::format(_("HP: %1$u/%2$u AT: %3$u/%4$u DE: %5$u/%6$u EV: %7$u/%8$u"))
34+ % soldier->get_hp_level() % soldier->get_max_hp_level()
35+ % soldier->get_attack_level() % soldier->get_max_attack_level()
36+ % soldier->get_defense_level() % soldier->get_max_defense_level()
37+ % soldier->get_evade_level() % soldier->get_max_evade_level()
38+ ).str()
39+ );
40 }
41
42 void SoldierList::eject(const Soldier * soldier)

Subscribers

People subscribed via source and target branches

to status/vote changes: