Code review comment for lp:~gue5t/midori/restore-middle-btn-up-2

Revision history for this message
Cris Dywan (kalikiana) wrote :

I'm afraid changing the signature of an existing signal is a bad idea, it will crash any existing extensions that use it.
We could consider this in the coming new trunk which breaks compat anyway - where there's the whole new question of porting to glib menu API.

review: Needs Fixing

« Back to merge proposal