Code review comment for lp:~gue5t/midori/gir-2

Revision history for this message
gue5t gue5t (gue5t) wrote :

> gir doesn't seem too happy with this
>
> katze/katze-item.c:278: Warning: Katze: katze_item_new: return value: Invalid
> non-constant of bare structure or union; register as boxed type (skip)

I asked in #introspection and apparently g-ir-scanner does not intuit which types are GObject classes from source code (G_DEFINE_TYPE) but requires to build a binary and run it to dump introspection data, so in our current build setup (running g-ir-scanner on source rather than an introspection dump) it doesn't realize that KatzeItem is a GObject class. This isn't, as far as I know, a sign that our annotations are incorrect. Ultimately we need to set up the buildsystem stuff to produce the introspection binary, but in the meantime I'd like to get this merged just so we have more annotations.

« Back to merge proposal