Merge lp:~gue5t/midori/app-resize into lp:midori

[gue5t gue5t]

Make application choosers resizable with a sane default size

Presently the chooser dialog for applications on the "open with" tab of preferences uses a fixed-size window that's uncomfortably small; it's too thin to read entire descriptions and too short to see more than two of the possibly many available applications for a given purpose.

This branch changes the dialog to be larger and resizable.

It also ensures that the dialog is always mapped with a "transient-for" parent, ensuring that it doesn't spawn outside the Midori window entirely in some window managers.

[Danielle Foré (danrabbit)]

Changes look sane. Works in gtk2 and 3. No more warning in terminal about no parent. Good job :)

review: Approve

=== modified file 'extensions/open-with.vala'
--- extensions/open-with.vala	2014-03-15 20:43:57 +0000
+++ extensions/open-with.vala	2015-03-24 03:15:27 +0000
@@ -375,7 +375,7 @@
 #endif
             destroy_with_parent = true;
             set_icon_name (Gtk.STOCK_OPEN);
-            resizable = false;
+            resizable = true;
             add_buttons (Gtk.STOCK_CANCEL, Gtk.ResponseType.CANCEL,
                          Gtk.STOCK_OPEN, Gtk.ResponseType.ACCEPT);
 
@@ -391,6 +391,15 @@
             vbox.pack_start (chooser, true, true, 0);
 
             get_content_area ().show_all ();
+
+            Gtk.Requisition req;
+#if HAVE_GTK3
+            get_content_area ().get_preferred_size (null, out req);
+#else
+            get_content_area ().size_request (out req);
+#endif
+            (this as Gtk.Window).set_default_size (req.width*2, req.height*3/2);
+
             set_default_response (Gtk.ResponseType.ACCEPT);
             chooser.selected.connect ((app_info) => {
                 response (Gtk.ResponseType.ACCEPT);
@@ -439,6 +448,7 @@
             update_label ();
 
             clicked.connect (() => {
+                dialog.transient_for = this.get_toplevel () as Gtk.Window;
                 app_info = dialog.open_with ();
                 string new_commandline = app_info != null ? get_commandline (app_info) : null;
                 commandline = new_commandline;