charm-k8s-gunicorn

Code review comment for ~gtrkiller/charm-k8s-gunicorn:master

  1. Git
  2. lp:~gtrkiller/charm-k8s-gunicorn
  3. master
  4. Merge into master
Revision history for this message
Tom Haddon (mthaddon) wrote :

Some comments inline.

Also, I get a `ModuleNotFoundError: No module named 'charms'` error from `make test`. I think you'll want to update tox.ini in the testenv:unit target from:

PYTHONPATH={toxinidir}/src:{toxinidir}/build/lib:{toxinidir}/build/venv

To:

PYTHONPATH={toxinidir}/src:{toxinidir}/lib

« Back to merge proposal