GTG

Code review comment for lp:~gtg-contributors/gtg/bug495246

Revision history for this message
Izidor MatuĊĦov (izidor) wrote :

Hi Joao,

Nobody reviews your code so far, I'll do it now :-) It looks great and also works great for adding new tags. There are just one problem which should be fixed:

Removing tags does not work well, mostly the task has more than one instance of that tag. You probably use iterators not in the way as it was meant: (I've got this error)

/home/iyo/downloads/bug495246/GTG/gtk/editor/taskview.py:743: GtkWarning: Invalid text buffer iterator: either the iterator is uninitialized, or the characters/pixbufs/widgets in the buffer have been modified since the iterator was created.
You must use marks, character numbers, or line numbers to preserve a position across buffer modifications.
You can apply tags and insert marks without invalidating your iterators,
but any mutation that affects 'indexable' buffer contents (contents that can be referred to by character offset)
will invalidate all outstanding iterators
  if start.get_offset() <= offset2 <= end.get_offset():

review: Needs Resubmitting (code + running the code)

« Back to merge proposal