Code review comment for lp:~graeme-acm/sahana-eden/LA

Revision history for this message
Fran Boon (flavour) wrote :

Please add the binary to the bzr ignore list - this will mean an uncommit 1st
- the repo has got huge & this very large binary really need removing rather than making it even bigger (this is what we do for the Google closure compiler.
A Raise if the .jar not found is just fine...a fancy script to auto-download can come later as-opportunity presents.

Yes please to avoid code duplication through nested calls.

review: Needs Fixing

« Back to merge proposal