Code review comment for lp:~gothicx/apport/cache_dir_remove

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Hi!

It worked without it. Check bug 416804 and Markus Korn comment. Maybe he didn't update the documentation.

> Hello Marco,
>
> Marco Rodrigues [2009-09-03 23:25 -0000]:
> > - self.__launchpad = Launchpad(credentials,
> launchpad_instance, cache_dir)
> > + self.__launchpad = Launchpad(credentials,
> launchpad_instance)
>
> The official documentation says that this needs cache_dir:
>
> https://help.launchpad.net/API/launchpadlib
>
> Why did you remove it?
>
> Martin
>
> --
> Martin Pitt | http://www.piware.de
> Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

« Back to merge proposal