Code review comment for lp:~gordallott/unity/hud

Michal Hruby (mhr3) wrote :

49 self->connected_ = true;
50 - self->owner_->connected.emit();

So can we at least not fool IsConnected() users (ie remove the "self->connected_ = true;" as well pls)

150 + GVariant* query_key = g_variant_get_child_value(query, 2);

Please check that the variant has at least 2 children (or at least that query_key != NULL)

153 + GVariant* queries = g_variant_get_child_value(query, 1);
173, 176, 189, 192

Same

« Back to merge proposal