Merge lp:~googol-deactivatedaccount/openlp/bug-789929 into lp:openlp

Proposed by Andreas Preikschat
Status: Merged
Approved by: Tim Bentley
Approved revision: 1596
Merged at revision: 1595
Proposed branch: lp:~googol-deactivatedaccount/openlp/bug-789929
Merge into: lp:openlp
Diff against target: 36 lines (+11/-5)
1 file modified
openlp/core/ui/displaytagform.py (+11/-5)
To merge this branch: bzr merge lp:~googol-deactivatedaccount/openlp/bug-789929
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Jonathan Corwin (community) Approve
Review via email: mp+62892@code.launchpad.net

Description of the change

Hello,

- Fixed bug #789929 (Display Tags cannot be deleted)

To post a comment you must log in.
Revision history for this message
Jonathan Corwin (j-corwin) :
review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/ui/displaytagform.py'
2--- openlp/core/ui/displaytagform.py 2011-05-26 18:00:25 +0000
3+++ openlp/core/ui/displaytagform.py 2011-05-30 15:15:52 +0000
4@@ -147,6 +147,7 @@
5 DisplayTags.remove_html_tag(self.selected)
6 self.selected = -1
7 self._resetTable()
8+ self._saveTable()
9
10 def onSavedPushed(self):
11 """
12@@ -171,14 +172,19 @@
13 html[u'end tag'] = u'{/%s}' % tag
14 self.selected = -1
15 self._resetTable()
16- temp = []
17+ self._saveTable()
18+
19+ def _saveTable(self):
20+ """
21+ Saves all display tags except protected ones.
22+ """
23+ tags = []
24 for tag in DisplayTags.get_html_tags():
25 if not tag[u'protected']:
26- temp.append(tag)
27- if temp:
28- ctemp = cPickle.dumps(temp)
29+ tags.append(tag)
30+ if tags:
31 QtCore.QSettings().setValue(u'displayTags/html_tags',
32- QtCore.QVariant(ctemp))
33+ QtCore.QVariant(cPickle.dumps(tags)))
34 else:
35 QtCore.QSettings().setValue(u'displayTags/html_tags',
36 QtCore.QVariant(u''))