Merge lp:~googol-deactivatedaccount/openlp/bug-768495 into lp:openlp
Status: | Merged |
---|---|
Approved by: | Raoul Snyman |
Approved revision: | 1826 |
Merged at revision: | 1840 |
Proposed branch: | lp:~googol-deactivatedaccount/openlp/bug-768495 |
Merge into: | lp:openlp |
Diff against target: |
173 lines (+102/-7) 2 files modified
openlp/core/ui/shortcutlistform.py (+5/-2) openlp/core/utils/actions.py (+97/-5) |
To merge this branch: | bzr merge lp:~googol-deactivatedaccount/openlp/bug-768495 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raoul Snyman | Approve | ||
Tim Bentley | Approve | ||
Review via email: mp+85891@code.launchpad.net |
This proposal supersedes a proposal from 2011-12-14.
Commit message
bzr commit -m "fixed bug #768495 (Shortcut can be assigned twice in certain circumstances)" --fixes lp:768495
Description of the change
Hello,
Fixed bug 768495 (Shortcut can be assigned twice in certain circumstances)
Description of the fix:
1) Create a dict with the shortcuts as keys and a list of actions using this shortcut as value.
2) When we add a new action/shortcut we check if the shortcut is valid. If this is the case we add it to the dict and if not we remove the shortcut.
Possible space for improvements:
- notify the user that a shortcut has been disabled
- make sure that shortcuts with lower priority are disabled if there should be a conflict (currently we remove the shortcut from the last actions)
How to test this?
1) Assign "R" to the "Re-index tool" action
2) Disable the songs plugin
3) Assign "R" to another action
4) Enable the songs plugin
Resolved conflict