Merge lp:~goldencako/parcel-tracker/parcel-tracker into lp:parcel-tracker

Proposed by cako
Status: Merged
Approved by: Vsevolod Velichko
Approved revision: 85
Merged at revision: 83
Proposed branch: lp:~goldencako/parcel-tracker/parcel-tracker
Merge into: lp:parcel-tracker
Diff against target: 48 lines (+15/-6)
2 files modified
parcel_tracker_lib/post_services.py (+14/-5)
po/parcel-tracker.pot (+1/-1)
To merge this branch: bzr merge lp:~goldencako/parcel-tracker/parcel-tracker
Reviewer Review Type Date Requested Status
Vsevolod Velichko Approve
Review via email: mp+121271@code.launchpad.net

Description of the change

I obtained a tracker code that had comments on the package status. I updated the code to include this information, that can be important sometimes. Also, added the correct encoding for the url.

To post a comment you must log in.
Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Please, remove the .desktop file change from the diff.

review: Needs Fixing
85. By Carlos da Costa <email address hidden>

Switched .desktop file to previous (correct) version

Revision history for this message
cako (goldencako) wrote :

Done! Sorry about that, I must have changed it trying to build it!

Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Ok, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'parcel_tracker_lib/post_services.py'
--- parcel_tracker_lib/post_services.py 2012-08-23 13:27:43 +0000
+++ parcel_tracker_lib/post_services.py 2012-08-25 16:11:20 +0000
@@ -516,10 +516,19 @@
516516
517 url = 'http://websro.correios.com.br/sro_bin/txect01$.QueryList?P_LINGUA=001&P_TIPO=001&P_COD_UNI=%(number)s'517 url = 'http://websro.correios.com.br/sro_bin/txect01$.QueryList?P_LINGUA=001&P_TIPO=001&P_COD_UNI=%(number)s'
518 def _parse_page(self, html):518 def _parse_page(self, html):
519 html = html.decode('utf-8', 'ignore')519 html = html.decode('ISO-8859-1', 'ignore')
520 res = re.findall(r'<td rowspan=1>(.*?)</td><td>(.*?)</td><td><FONT COLOR=".*?">(.*?)</font></td>',520 res = re.findall(r'<tr><td rowspan=.*?>(.*?)</td><td>(.*?)</td><td><FONT COLOR=".*?">(.*?)</font></td></tr>(?:\s*?<tr><td colspan=2>(.*?)</td></tr>)?',
521 html, re.DOTALL|re.IGNORECASE)521 html, re.DOTALL|re.IGNORECASE|re.UNICODE)
522 return [ (op, parsedate(date, dayfirst=True), ' '.join(post.split())) for (date, post, op) in res]522 result = []
523 for (date, post, op, obs) in res:
524 resdate = parsedate(date, dayfirst=True)
525 respost = u' '.join(post.split())
526 if obs:
527 resop = u' '.join(op.split() + [u'-'] + obs.split())
528 else:
529 resop = u' '.join(op.split())
530 result.append((resop, resdate, respost))
531 return result
523532
524if __name__ == '__main__':533if __name__ == '__main__':
525 logging.basicConfig(level=logging.DEBUG, format="%(asctime)s - %(levelname)s - %(message)s")534 logging.basicConfig(level=logging.DEBUG, format="%(asctime)s - %(levelname)s - %(message)s")
@@ -537,6 +546,6 @@
537 #service = UkrposhtaComService('RB041697087UA')546 #service = UkrposhtaComService('RB041697087UA')
538 #service = DhlDeService('129921786448')547 #service = DhlDeService('129921786448')
539 #service = UpsComService('1Z882E910397601345')548 #service = UpsComService('1Z882E910397601345')
540 service = CorreiosComService('RQ867951061BR')549 service = CorreiosComService('RD024810847SE')
541 for i in service.fetch():550 for i in service.fetch():
542 print u'\t'.join([unicode(j) for j in i])551 print u'\t'.join([unicode(j) for j in i])
543552
=== modified file 'po/parcel-tracker.pot'
--- po/parcel-tracker.pot 2012-07-13 18:31:55 +0000
+++ po/parcel-tracker.pot 2012-08-25 16:11:20 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: PACKAGE VERSION\n"9"Project-Id-Version: PACKAGE VERSION\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2012-07-13 22:30+0400\n"11"POT-Creation-Date: 2012-08-23 12:50-0300\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"

Subscribers

People subscribed via source and target branches