Merge lp:~goldencako/parcel-tracker/parcel-tracker into lp:parcel-tracker

Proposed by cako
Status: Merged
Approved by: Vsevolod Velichko
Approved revision: 85
Merged at revision: 83
Proposed branch: lp:~goldencako/parcel-tracker/parcel-tracker
Merge into: lp:parcel-tracker
Diff against target: 48 lines (+15/-6)
2 files modified
parcel_tracker_lib/post_services.py (+14/-5)
po/parcel-tracker.pot (+1/-1)
To merge this branch: bzr merge lp:~goldencako/parcel-tracker/parcel-tracker
Reviewer Review Type Date Requested Status
Vsevolod Velichko Approve
Review via email: mp+121271@code.launchpad.net

Description of the change

I obtained a tracker code that had comments on the package status. I updated the code to include this information, that can be important sometimes. Also, added the correct encoding for the url.

To post a comment you must log in.
Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Please, remove the .desktop file change from the diff.

review: Needs Fixing
85. By Carlos da Costa <email address hidden>

Switched .desktop file to previous (correct) version

Revision history for this message
cako (goldencako) wrote :

Done! Sorry about that, I must have changed it trying to build it!

Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Ok, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'parcel_tracker_lib/post_services.py'
2--- parcel_tracker_lib/post_services.py 2012-08-23 13:27:43 +0000
3+++ parcel_tracker_lib/post_services.py 2012-08-25 16:11:20 +0000
4@@ -516,10 +516,19 @@
5
6 url = 'http://websro.correios.com.br/sro_bin/txect01$.QueryList?P_LINGUA=001&P_TIPO=001&P_COD_UNI=%(number)s'
7 def _parse_page(self, html):
8- html = html.decode('utf-8', 'ignore')
9- res = re.findall(r'<td rowspan=1>(.*?)</td><td>(.*?)</td><td><FONT COLOR=".*?">(.*?)</font></td>',
10- html, re.DOTALL|re.IGNORECASE)
11- return [ (op, parsedate(date, dayfirst=True), ' '.join(post.split())) for (date, post, op) in res]
12+ html = html.decode('ISO-8859-1', 'ignore')
13+ res = re.findall(r'<tr><td rowspan=.*?>(.*?)</td><td>(.*?)</td><td><FONT COLOR=".*?">(.*?)</font></td></tr>(?:\s*?<tr><td colspan=2>(.*?)</td></tr>)?',
14+ html, re.DOTALL|re.IGNORECASE|re.UNICODE)
15+ result = []
16+ for (date, post, op, obs) in res:
17+ resdate = parsedate(date, dayfirst=True)
18+ respost = u' '.join(post.split())
19+ if obs:
20+ resop = u' '.join(op.split() + [u'-'] + obs.split())
21+ else:
22+ resop = u' '.join(op.split())
23+ result.append((resop, resdate, respost))
24+ return result
25
26 if __name__ == '__main__':
27 logging.basicConfig(level=logging.DEBUG, format="%(asctime)s - %(levelname)s - %(message)s")
28@@ -537,6 +546,6 @@
29 #service = UkrposhtaComService('RB041697087UA')
30 #service = DhlDeService('129921786448')
31 #service = UpsComService('1Z882E910397601345')
32- service = CorreiosComService('RQ867951061BR')
33+ service = CorreiosComService('RD024810847SE')
34 for i in service.fetch():
35 print u'\t'.join([unicode(j) for j in i])
36
37=== modified file 'po/parcel-tracker.pot'
38--- po/parcel-tracker.pot 2012-07-13 18:31:55 +0000
39+++ po/parcel-tracker.pot 2012-08-25 16:11:20 +0000
40@@ -8,7 +8,7 @@
41 msgstr ""
42 "Project-Id-Version: PACKAGE VERSION\n"
43 "Report-Msgid-Bugs-To: \n"
44-"POT-Creation-Date: 2012-07-13 22:30+0400\n"
45+"POT-Creation-Date: 2012-08-23 12:50-0300\n"
46 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
47 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
48 "Language-Team: LANGUAGE <LL@li.org>\n"

Subscribers

People subscribed via source and target branches