Merge lp:~goelkunal/kdelibs/debian into lp:~kubuntu-packagers/kubuntu-packaging/kdelibs
Proposed by
KunalGoel
Status: | Merged |
---|---|
Merge reported by: | Jonathan Riddell |
Merged at revision: | not available |
Proposed branch: | lp:~goelkunal/kdelibs/debian |
Merge into: | lp:~kubuntu-packagers/kubuntu-packaging/kdelibs |
Diff against target: |
132 lines (+112/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/remove-direct-OpenGL-dependency-for-libplasma.diff (+104/-0) debian/patches/series (+1/-0) |
To merge this branch: | bzr merge lp:~goelkunal/kdelibs/debian |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Riddell | Approve | ||
Steve Langasek | Approve | ||
Review via email: mp+51994@code.launchpad.net |
Description of the change
remove direct OpenGL dependency for libplasma
To post a comment you must log in.
The patch itself seems to be straightforward, but why are the glClearColor(), glClear() calls not needed here? Presumably they were added for a reason, and we should be sure that reason no longer applies before making such a change.
I see that these API calls are also part of GLES; so if these calls need to be kept, an alternative would be for plasma to select either GL or GLES as needed.