Merge lp:~gnuoy/charms/trusty/keystone/restart-horror into lp:~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Liam Young
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~gnuoy/charms/trusty/keystone/restart-horror
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 46 lines (+12/-2)
3 files modified
hooks/config-changed (+9/-0)
hooks/keystone_hooks.py (+1/-1)
hooks/keystone_utils.py (+2/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/keystone/restart-horror
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+274556@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

189. By Liam Young

Restart hook after upgrade

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified symlink 'hooks/config-changed' (properties changed: -x to +x)
=== target was u'keystone_hooks.py'
--- hooks/config-changed 1970-01-01 00:00:00 +0000
+++ hooks/config-changed 2015-10-15 13:31:32 +0000
@@ -0,0 +1,9 @@
1#!/bin/bash
2
3./hooks/config-changed.real
4RC=$?
5if [[ $RC -eq 200 ]]; then
6 ./hooks/config-changed.real
7 RC=$?
8fi
9exit $RC
010
=== modified file 'hooks/keystone_hooks.py'
--- hooks/keystone_hooks.py 2015-10-08 22:29:33 +0000
+++ hooks/keystone_hooks.py 2015-10-15 13:31:32 +0000
@@ -129,7 +129,7 @@
129 git_install(config('openstack-origin-git'))129 git_install(config('openstack-origin-git'))
130130
131131
132@hooks.hook('config-changed')132@hooks.hook('config-changed.real')
133@restart_on_change(restart_map())133@restart_on_change(restart_map())
134@synchronize_ca_if_changed(fatal=True)134@synchronize_ca_if_changed(fatal=True)
135def config_changed():135def config_changed():
136136
=== modified file 'hooks/keystone_utils.py'
--- hooks/keystone_utils.py 2015-10-06 19:19:34 +0000
+++ hooks/keystone_utils.py 2015-10-15 13:31:32 +0000
@@ -1,4 +1,5 @@
1#!/usr/bin/python1#!/usr/bin/python
2import sys
2import glob3import glob
3import grp4import grp
4import hashlib5import hashlib
@@ -396,7 +397,7 @@
396 log("Database not ready - deferring to shared-db relation",397 log("Database not ready - deferring to shared-db relation",
397 level=INFO)398 level=INFO)
398 return399 return
399400 sys.exit(200)
400401
401def is_db_initialised():402def is_db_initialised():
402 if relation_ids('cluster'):403 if relation_ids('cluster'):

Subscribers

People subscribed via source and target branches