Code review comment for lp:~gnuoy/charms/trusty/cinder-ceph/1453940

Revision history for this message
Ryan Beisner (1chb1n) wrote :

The proposed changes appear to cause additional subordinate relation data (request-id). If this is an expected behavior change, the amulet test will need to be updated accordingly.

Here's where it tripped:

actual relation data (partial):
 'broker_req': '{"api-version": 1, "request-id": "5e38da9e-5635-11e5-9a6a-fa163ee76ffe", "ops": [{"replicas": 3, "name": "cinder-ceph", "op": "create-pool"}]}'}

expected relation data (partial):
 'broker_req': '{"api-version": 1, "ops": [{"replicas": 3, "name": "cinder-ceph", "op": "create-pool"}]}'}

Thanks - holler with any questions!

review: Needs Fixing

« Back to merge proposal