Code review comment for lp:~gnuoy/charms/trusty/ceph/fix-1409698

Revision history for this message
Ryan Beisner (1chb1n) wrote :

P, T, U & J deploy tests fail with:

http://10.245.162.77:8080/view/Dashboard%3A%20Deploy/job/deploy_with_deployer/1213/artifact/

02:07:59 2015-01-13 02:07:59 [DEBUG] deployer.import: Waiting for relation convergence 60s
02:08:59 2015-01-13 02:09:00 [ERROR] deployer.env: The following units had errors:
02:08:59 unit: ceph/2: machine: 4 agent-state: error details: hook failed: "client-relation-changed"
02:08:59 unit: ceph/1: machine: 3 agent-state: error details: hook failed: "client-relation-changed"
02:08:59 unit: ceph/0: machine: 2 agent-state: error details: hook failed: "client-relation-changed"
02:08:59 2015-01-13 02:09:00 [INFO] deployer.cli: Deployment stopped. run time: 560.19

2015-01-13 02:07:56 INFO juju.worker.uniter uniter.go:480 running "client-relation-changed" hook
2015-01-13 02:07:56 INFO client-relation-changed Traceback (most recent call last):
2015-01-13 02:07:56 INFO client-relation-changed File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/client-relation-changed", line 337, in <module>
2015-01-13 02:07:56 INFO client-relation-changed hooks.execute(sys.argv)
2015-01-13 02:07:56 INFO client-relation-changed File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/charmhelpers/core/hookenv.py", line 528, in execute
2015-01-13 02:07:56 INFO client-relation-changed self._hooks[hook_name]()
2015-01-13 02:07:56 INFO client-relation-changed File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/client-relation-changed", line 304, in client_relation_changed
2015-01-13 02:07:56 INFO client-relation-changed settings = relation_get(rid=relid)
2015-01-13 02:07:56 INFO client-relation-changed NameError: global name 'relid' is not defined
2015-01-13 02:07:56 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1

review: Needs Fixing

« Back to merge proposal