Merge ~gnuoy/charms/+source/interface-rabbitmq:master into ~openstack-charmers-layers/charms/+source/interface-rabbitmq:master

Proposed by Liam Young
Status: Merged
Merged at revision: 1b0ca5b98363888c1fcc1035ef1481637efb7abf
Proposed branch: ~gnuoy/charms/+source/interface-rabbitmq:master
Merge into: ~openstack-charmers-layers/charms/+source/interface-rabbitmq:master
Diff against target: 36 lines (+13/-5)
1 file modified
requires.py (+13/-5)
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+279743@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/requires.py b/requires.py
index 06c9fc2..7a50d66 100644
--- a/requires.py
+++ b/requires.py
@@ -35,18 +35,26 @@ class RabbitMQRequires(RelationBase):
35 def joined(self):35 def joined(self):
36 self.set_state('{relation_name}.connected')36 self.set_state('{relation_name}.connected')
3737
38 @hook('{requires:rabbitmq}-relation-changed')38 def update_state(self):
39 def changed(self):
40 if self.base_data_complete():39 if self.base_data_complete():
41 self.set_state('{relation_name}.available')40 self.set_state('{relation_name}.available')
42 if self.ssl_data_complete():41 if self.ssl_data_complete():
43 self.set_state('{relation_name}.available.ssl')42 self.set_state('{relation_name}.available.ssl')
43 else:
44 self.remove_state('{relation_name}.available.ssl')
45 else:
46 self.remove_state('{relation_name}.available')
47 self.remove_state('{relation_name}.available.ssl')
48 if not self.rabbitmq_hosts():
49 self.remove_state('{relation_name}.connected')
50
51 @hook('{requires:rabbitmq}-relation-changed')
52 def changed(self):
53 self.update_state()
4454
45 @hook('{requires:rabbitmq}-relation-{broken,departed}')55 @hook('{requires:rabbitmq}-relation-{broken,departed}')
46 def departed(self):56 def departed(self):
47 self.remove_state('{relation_name}.connected')57 self.update_state()
48 self.remove_state('{relation_name}.available')
49 self.remove_state('{relation_name}.available.ssl')
5058
51 def base_data_complete(self):59 def base_data_complete(self):
52 """60 """

Subscribers

People subscribed via source and target branches