Merge lp:~gnuoy/charm-helpers/get-hwaddr into lp:charm-helpers
Proposed by
Liam Young
Status: | Merged |
---|---|
Approved by: | Gareth Woolridge |
Approved revision: | 106 |
Merged at revision: | 104 |
Proposed branch: | lp:~gnuoy/charm-helpers/get-hwaddr |
Merge into: | lp:charm-helpers |
Diff against target: |
73 lines (+23/-5) 3 files modified
charmhelpers/core/host.py (+10/-0) tests/contrib/charmsupport/test_nrpe.py (+4/-5) tests/core/test_host.py (+9/-0) |
To merge this branch: | bzr merge lp:~gnuoy/charm-helpers/get-hwaddr |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gareth Woolridge | Approve | ||
Review via email: mp+197172@code.launchpad.net |
Description of the change
* Fix to tests broken by previous nrpe update
* Function with test to get the hardware address for a given nic
To post a comment you must log in.
Looks good to me with the update to the test as discussed.