Code review comment for lp:~gnumdk/libdbusmenu-qt/fix-dropdown-firefox

Revision history for this message
Charles Kerr (charlesk) wrote :

...actually, even if we use some portable monotonically increasing timestamp, that still won't work because it'll disagree with the X11 time that gdk is passing along to FF elsewhere. So in the absence of a better solution we should try to use the X11 timestamp when available and keep the old behavior the rest of the time.

Cédric, please add the #ifdef wrappers and we'll run it through CI again, something like:

#if defined(Q_WS_X11)
#include <QX11Info>


#if defined(Q_WS_X11)
 uint timestamp = QX11Info::appTime();
        timestamp = QDateTime::currentDateTime().toTime_t();

« Back to merge proposal