e531204...
by
Philip Withnall <email address hidden>
packagekit: Remove redundant calls to pk_client_set_background()
`pk_client_set_background()` and `pk_client_set_interactive()` are
called by `gs_packagekit_task_setup()`, so calling them just before
calling it is redundant.
This introduces no functional changes for most of these call sites
*apart from* `gs_plugin_app_upgrade_download()`, `_download_only()` and
`gs_plugin_packagekit_refresh_metadata_async()`.
At those sites, the intention of the code seemed to be to
unconditionally set `background=TRUE`, but the subsequent call to
`gs_packagekit_task_setup()` was undoing that work. Following the logic
of the comment in `gs_packagekit_task_setup()`, it seems more consistent
and still correct to set `background=!interactive` as with all the other
call sites.
The use of `background=TRUE` in these call sites may have dated from
before the interactive state was properly exposed to those bits of code,
and hence the background/interactive state passed to PackageKit had to
be hard-coded.
Signed-off-by: Philip Withnall <email address hidden>
