lp:gnome-software

Author: Efstathios Iosifidis
Author Date: 2021-01-24 09:35:24 UTC

Update Greek translation

Author: Milan Crha
Author Date: 2021-01-22 11:49:28 UTC

gs-installed-page: Filter out uninstalled local applications

The usual state after cancelled install is "available", but local
packages have the state changed to "local", which was not in the list
of "states to remove the application row due". Rather than adding
the "local" state to the list name only allowed states in the list.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/985

Author: Milan Crha
Author Date: 2021-01-21 14:55:19 UTC

flatpak: Cover addons on install/uninstall of the application

When installing/uninstalling an application install/uninstall
also its addons - those being checked for install on install,
those being installed on uninstall.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/998

Author: Milan Crha
Author Date: 2021-01-21 11:14:34 UTC

gs-plugin-packagekit-proxy: Skip the setting when the host is empty

It avoids to set invalid proxy URL to the PackageKit.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1001

Author: Phaedrus Leeds
Author Date: 2021-01-21 02:16:03 UTC

Merge branch 'metered-data-remove-entry' into 'master'

gs-metered: Remove Mogwai schedule entries when downloads are complete

See merge request GNOME/gnome-software!463

Author: Milan Crha
Author Date: 2021-01-20 19:11:51 UTC

gs-updates-section: Auto-hide itself when all rows are removed

Also remove applications from the application list on their removal,
thus the internal application list matches content of the GUI part.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/670

Author: Matthias Klumpp
Author Date: 2021-01-09 02:28:39 UTC

hack: Make CI work (temporary commit)

Just mess around with the CI config to make the CI work until the MR is
merged and we have it adjusted properly.

Author: Phaedrus Leeds
Author Date: 2021-01-08 21:42:00 UTC

Merge branch 'backport-517-packagekit-ids-gnome-3-38' into 'gnome-3-38'

Backport !517 “packagekit: Package details not found when not having 4 semicolons” to gnome-3-38

See merge request GNOME/gnome-software!578

Author: Milan Crha
Author Date: 2020-10-06 12:25:24 UTC

misc: Add .gitignore file

The `git status -u` shows the whole content of the top directories of
the `subprojects` directory, making it too easy to overlook some files
not being part of the git checkout, when they are supposed to be there.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/513

Author: Milan Crha
Author Date: 2020-09-18 08:17:14 UTC

gs-details-page: GsInfoBar doesn't paint in the details page

An info bar packed in the middle of the window requires its own window,
to be drawn properly.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1065
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/510

Author: Boyuan Yang
Author Date: 2020-08-31 14:30:14 UTC

Update Chinese (China) translation

Author: Phaedrus Leeds
Author Date: 2020-08-13 19:23:58 UTC

Save install queue in separate dir for each unit test

Currently some unit tests fail with a message like:
Bail out! Gs-FATAL-WARNING: failed to create an app for */*/*/*/chiron.desktop/*

This is because the tests are being run in parallel, and in
gs_plugin_loader_setup() we load the install queue from the disk, but
the queue is also being written to by other tests so it may have apps in
it which can't be understood by the plugin being tested (chiron.desktop
is only used by the dummy plugin).

So, read and write the install queue from a temporary directory that is
unique to each self test, using an env var set only by those tests. One
might wonder if we could instead use G_TEST_OPTION_ISOLATE_DIRS, but
that only takes effect during g_test_run() and we call
gs_plugin_loader_setup() before that. Another option would be a
gs_plugin_loader_override_install_dir() function but using an env var is
more consistent with how we do similar overrides, e.g.
GS_SELF_TEST_CACHEDIR.

Author: Matthew Leeds
Author Date: 2020-07-08 23:27:09 UTC

flatpak: Set apps to installed upon missing runtime install

This commit is a rework of
https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/373

The idea is that when an app's runtime is missing, or one of its
should-download related refs is missing, the app will be returned as
updatable by flatpak_installation_list_installed_refs_for_update(), and
will be subsequently added to a transaction by gnome-software. Progress
updates on the app are calculated using the progress of the related
operations. However if the app itself doesn't need an update,
_transaction_operation_done() will never be called for it and so its
state never gets set to AS_APP_STATE_INSTALLED. Fix this by setting the
app to installed when the related thing is, if the app is being skipped
and the related thing is the last operation in the transaction needed
for the app.

It would be great to add a unit test for this, but there's no way
through the flatpak plugin's API to uninstall an app's runtime without
uninstalling the app, so we'd have to do something tricky like call out
to "flatpak uninstall --force-remove ..."

Author: Matthew Leeds
Author Date: 2020-02-22 01:00:29 UTC

flatpak: Add app to be uninstalled to txn cache

This mirrors what we do for install operations, and ensures that the
GsApp object used by the GsFlatpakTransaction will be the same one which
was passed to gs_plugin_app_remove(), which prevents this warning:

(/builds/mwleeds/gnome-software/_build/plugins/flatpak/gs-self-test-flatpak:1689):
Gs-WARNING **: 21:05:06.803: application
user/flatpak/chiron1-origin/desktop/org.test.Chiron/master left in
removing helper

Author: Kalev Lember
Author Date: 2020-05-04 12:08:08 UTC

Don't offer Fedora distro upgrades if we don't have correct artwork

Make sure we have the artwork for the distro upgrade banner before
offering an upgrade. In practice, this means that we don't offer a
distro upgrade at all unless the user has first updated gnome-software
to the version available from in the updates repo.

This comes with a slight tradeoff that some people who never install
regular updates will not get the distro upgrade notification at all
after this change.

Author: Richard Hughes
Author Date: 2020-04-29 11:54:04 UTC

fwupd: Only delete the installed archive if we downloaded it to the cache

If the user double clicks on a .cab file on a USB stick to install it, it is
certainly not expected we delete the archive when it has been scheduled.

Author: Muhammet Kara
Author Date: 2020-04-23 20:08:33 UTC

Update Turkish translation

Author: wsxy162
Author Date: 2020-04-18 09:38:20 UTC

Update zh_CN translations

Author: wsxy162
Author Date: 2020-04-18 09:38:20 UTC

Update zh_CN translations

Author: Umang Jain
Author Date: 2019-11-22 06:45:37 UTC

transaction: Sync installed apps' state missing runtime is re-installed

Flatpak changes [1] will start marking apps as updatable if their
runtime component is missing on the installation. These apps will
be shown as updatable in gnome-software updates panel but in the
background they are meant to fetch their missing runtime.

Since many apps can target one runtime, the absence of that runtime
can make many apps show up in the updates panel. In that case,
check if the runtime is downloaded → installed and set all
apps' state back to "installed". This solves the case
if users chooses to click "Update All".

[1] https://github.com/flatpak/flatpak/pull/3204

https://phabricator.endlessm.com/T27077

Author: Kalev Lember
Author Date: 2019-10-04 10:58:09 UTC

update monitor: Show a notification when an app requires new permissions

Don't just silently skip apps that require new permissions, but instead
show a shell notification with the app name so that the user knows that
it has been kept back.

Author: Richard Hughes
Author Date: 2019-06-20 10:38:48 UTC

fwupd: Use custom GsApp GType

Author: Jonathan Kang
Author Date: 2019-11-18 07:27:26 UTC

build: Bump fwupd dependency to 1.2.7

In commit 28dd972a, fwupd_release_get_categories() was called. While
this is an API introced in fwupd 1.2.7. So bump the fwupd dependency
accordingly.

Author: Kalev Lember
Author Date: 2019-11-12 21:16:49 UTC

Pass GsPluginJob to plugins

Author: Umang Jain
Author Date: 2019-10-10 05:14:50 UTC

appstream: Override <id> with <launchable type="desktop-id"> while parsing appdata files

Problem statement:
This has been a recurring problem since a long time now, where
apps have started to drop the ".desktop" suffix from their <id>
tag present in their appdata. Reasoning for this change is given
as the ".desktop" is not really a part of the app-id. Also,
it's been seen as better aligning with flatpak ref-ids as
dropping this suffix makes the app-id equivalent to the flatpak
ref-id.

However, this breaks the mapping between the app's appdata and
it's desktop file. GNOME Software parses both of these, to merge
the metadata (ideally) under one GsApp object during refines.
The appdata supplies information like description and categories
whereas desktop files supplies information like icon, NoDisplay
and so on.

So, things will break if metadata parsing of appdata and desktop
file doesn't converge under one GsApp object. What happens here
is gnome-software creates an app from a desktop file but could
not relate to it's appdata file (because ".desktop" mismatch) and
it ends up creating two GsApp objects, neither of which has full
metadata from appdata and desktop file. Hence, anyone of these can
bubble up in the UI with missing icons or info etc.

Solution:
Apps dropping .desktop suffix adds a <launchable type="desktop-id">
tag to the appdata. Check for the presence of this tag and override
the <id> tag, if it doesn't match the <launchable> tag. This makes
sure that the appdata can still relate to it's desktop file component.

https://phabricator.endlessm.com/T27779

Author: jimmac
Author Date: 2019-11-06 19:19:33 UTC

stylesheet: define category tile colors

Addresses the stylesheet side of https://gitlab.gnome.org/GNOME/gnome-software/issues/65

Author: Richard Hughes
Author Date: 2019-10-11 15:56:03 UTC

Do not show non-applications in the installed panel

Author: Kalev Lember
Author Date: 2019-10-04 11:26:33 UTC

updates monitor: Don't skip automatic updates that require new permissions

This is a workaround for 3.34.x to avoid holding back updates to any
apps that require new permissions, as per aday's guidance.

For master, this is fixed in a better way (https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/329)
where we show a shell notification that tells the user that they need to
review apps that need new permissions.

Author: id:sicklylife
Author Date: 2019-09-28 10:09:24 UTC

Update Japanese translation

Author: Umang Jain
Author Date: 2019-09-20 06:10:00 UTC

external-appstream: Don't bother about permissions while copying

Don't bother with permissions while copying the external appstream
file from user's cache to APPSYSTEM_SYSTEM_DIR. This already has been
now taken care of by the change introduced in [1].

This reason this change is required, is because combination of [1]
and G_FILE_COPY_TARGET_DEFAULT_PERMS ends up with permissions as:
-rw------- 1 root root
as G_FILE_COPY_TARGET_DEFAULT makes entire "unix::mode" attribute
to be skipped while copying.

Since, as per [1], G_FILE_CREATE_PRIVATE will setup appropriate
permissions on the destination file itself, avoid injecting
the G_FILE_COPY_TARGET_DEFAULT flag in g_file_copy() to complicate
the matter.

(Unfortunately, this requires a glib version bump for upstream)

[1] https://gitlab.gnome.org/GNOME/glib/merge_requests/876

https://phabricator.endlessm.com/T27828

Author: Umang Jain
Author Date: 2019-09-18 15:45:58 UTC

fixup! appstream: Also query the real appdata files during refine

Author: Umang Jain
Author Date: 2019-08-06 11:24:31 UTC

flatpak: Introduce a utility to resolve default arch for refs

This is originated to address the case of external-appstream
that can be used to mention additional appdata for a given GsApp.
However, the `source` parameter for a flatpak GsApp is dependent
on the arch of the system. This patch allows the external appstream
to optionally omit the arch and gnome-software will assume the
default arch and re-create the source parameter with the correct ref.
The corrected ref is parsed through `flatpak_ref_parse` for sanity.

Example of an external appstream 'source' parameter resolution:
<bundle type="flatpak">app/org.telegram.desktop//stable</flatpak>
resolves to: `app/org.telegram.desktop/x86_64/stable` for a
x86_64 platform.

https://phabricator.endlessm.com/T26507

Author: Umang Jain
Author Date: 2018-08-20 11:12:00 UTC

New "online-updates-timestamp" gsetting for online updates tracking

"online-updates-timestamp" will denote the last time the system was
online and got any update. It will play as one of the factor to drive
pending updates notification logic in gs-update-monitor (See
no_updates_for_a_week). This timestamp is set by plugin-loader
whenever there is a update or upgrade operation (that succeeds).

The reason we introduce a new gsetting instead of using a similar
one "install-timestamp is that, "install-timestamp" is used for
scheduling offline PackageKit update notifications. If we reuse this
one for flatpak updates as well, this can lead to PackageKit updates
never getting any notifications (as flatpak updates are autoinstalled).

Based on Endless dev ticket:
https://phabricator.endlessm.com/T22720

https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/78

Author: Allan Day
Author Date: 2019-08-02 15:29:08 UTC

tweaks some of the featured app banners

Author: Umang Jain
Author Date: 2019-07-19 11:11:00 UTC

flatpak: Set main app as updatable if it's extension is updatable

Currently, the code does not follow the debug message above.
Hence, this patch tries to fix that, making main app as updatable
if any of it's extension is updatable.

Author: Richard Hughes
Author Date: 2017-08-05 13:16:24 UTC

Show a donation section in the review dialog

Additionally, allow admins to disable the donation functionality using a key in
GSettings.

Author: Kalev Lember
Author Date: 2019-07-09 15:50:41 UTC

Drop purchasing and auth support

This was only used by the snap plugin, which was dropped as Ubuntu is
switching to a new snap-store app instead of using gnome-software.

Author: Richard Hughes
Author Date: 2019-06-20 10:31:46 UTC

Allow GsApp objects to implement a custom cache key

This allows us to maintain a plugin cache when the unique ID is not unique
enough to disambiguate the objects. For instance, flatpak applications created
from an AppStream search result do not have a "branch" set.

Fixes https://gitlab.gnome.org/GNOME/gnome-software/issues/684

Author: Richard Hughes
Author Date: 2019-02-11 12:17:28 UTC

flatpak: Use a custom GsApp GTypes for results

Author: Allan Day
Author Date: 2019-05-30 10:59:33 UTC

updates

Author: Umang Jain
Author Date: 2019-05-06 11:48:47 UTC

flatpak: Introduce success/failure heuristics for app install

We want to pro-actively fail the install operations if we are
sure that we are running low on disk-space. This saves the network
bandwidth for user and reduce this cycle:
online fetch -> detect low disk free space -> cleanup.

* For app install:
  We make sure that there is enough space for app's download size +
  min-free-space (flatpak defaults to 500MB right now).

We might be interested to do similar for app updates and autoupdates
in following commits

Author: Joaquim Rocha
Author Date: 2018-05-14 15:02:44 UTC

Reset the progress to 0 when setting a non-action state

Per hughsie, when setting a non-action state, the apps' progress should
be reset to 0.

This patch adds that and also its coverage in the dummy plugin's tests.

Author: Kalev Lember
Author Date: 2019-01-02 07:56:29 UTC

flatpak: Launch apps via GAppInfo and the desktop file

Avoid directly using flatpak_installation_launch() and instead switch to
g_app_info_launch() so that we get a new terminal window for command
line apps.

Fixes: https://gitlab.gnome.org/GNOME/gnome-software/issues/552

Author: Richard Hughes
Author Date: 2018-11-26 16:28:41 UTC

Use cairo_surface_t rather than the deprecated GdkPixbuf for exported API

Note: we're still using GdkPixbuf as a file loader as cairo can only really
import PNGs rather than all the types supported in AppStream.

Author: Kalev Lember
Author Date: 2018-11-02 07:20:37 UTC

packagekit: Use the INTERACTIVE plugin flag

XXX: untested

Author: Kalev Lember
Author Date: 2018-09-27 18:09:28 UTC

origin popover row: Align items using a size group

Author: Kalev Lember
Author Date: 2018-09-24 14:14:59 UTC

details: Add a donate infobar as per latest mockups

Author: Joaquim Rocha
Author Date: 2018-07-05 21:40:20 UTC

flatpak: Add test for installing extensions when updating an app

When updating an app, if its runtime needs an extension and it's missing
(e.g. because it wasn't correctly installed before), then install the
extension while updating the app too.

Author: Joaquim Rocha
Author Date: 2018-07-05 21:40:20 UTC

flatpak: Add test for installing extensions when updating an app

When updating an app, if its runtime needs an extension and it's missing
(e.g. because it wasn't correctly installed before), then install the
extension while updating the app too.

Author: Richard Hughes
Author Date: 2016-04-27 18:52:04 UTC

Fix potential crash when icons are missing

Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=764921

Author: Joaquim Rocha
Author Date: 2018-06-20 15:03:28 UTC

Fix how pending apps are installed from the installed page

In the installed page, whenever the list of pending apps changes, the
page will try to install any app in it. This was fine when there were
no limited number of concurrent installations, but right now this may
be a problem (if an app that gets installed by the page goes in the
pending list, then this may trigger another install call from the page
and so on...).

Since the page only cares about installing the apps for when the list
of pending apps is loaded from disk (on start up), to prevent the issue
mentioned above these changes only install the pending apps on start up.
It also skips calling refine on all the pending apps after start up,
since apps are added to the pending apps list usually after being very
recently refined (i.e. we only need to refine them on start up, so this
patch may make things a bit faster in this regard).

https://phabricator.endlessm.com/T21194

Author: Joaquim Rocha
Author Date: 2018-05-18 15:23:53 UTC

flatpak: Refactor the plugin's setup method

https://phabricator.endlessm.com/T22617

Author: Joaquim Rocha
Author Date: 2018-05-09 13:55:49 UTC

Do not invalidate OS upgrades in the Updates page

The Updates page resets the OS upgrades state to be available again if
there's a change to the updates, or an app removal, etc.. The reason for
this is that package-based systems need to make sure they have all the
packages downloaded, so this would force the user to download any
missing packages.

As a result, if the user has a downloaded OS upgrade in an ostree system,
and restarts GNOME Software, or removes an app, in this state, the OS
upgrade will show the Download button again, even if offline.

Any OS upgrade invalidation should be done by the plugins related to it
and not by the Updates page, so this patch removes the mentioned code.

Author: Kalev Lember
Author Date: 2018-04-10 09:58:10 UTC

trivial: Post release version bump

Author: Joaquim Rocha
Author Date: 2018-03-19 15:57:53 UTC

Use the OS upgrade's cancellable object for related operations

Instead of creating its own cancellable for operations related to the OS
upgrade, we should use the OS upgrade's own cancellable object.
This will allow e.g. to connect the cancellable object from outside the
update page's code.

Author: Joaquim Rocha
Author Date: 2018-03-28 11:17:45 UTC

app-row: Only set the row's button as destructive when it removes an app

If the page is set as colorful, we should still not show the update
button as destructive. So it should only be set as such when the app
is installed (because the button will remove the app).

Author: Richard Hughes
Author Date: 2018-03-13 20:02:13 UTC

Sort the upgrades list chronologically

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1553792

Author: Kalev Lember
Author Date: 2018-02-28 15:21:20 UTC

repos dialog: Show "Remove All" instead of "Remove"

When removing a repo-release package, use "Remove All" to show that it
removes all repos that come from that package.

Author: Philip Chimento
Author Date: 2017-11-03 01:35:46 UTC

flatpak: Remove unused argument

https://phabricator.endlessm.com/T19806

Author: Kalev Lember
Author Date: 2018-01-12 09:19:03 UTC

GsPlugin: Avoid dereferencing self pointer before g_return_if_fail checks

Author: Richard Hughes
Author Date: 2018-02-16 20:32:04 UTC

trivial: Include the fwupd version in the useragent

See https://blogs.gnome.org/hughsie/2018/02/16/ for more details.

Author: Kalev Lember
Author Date: 2017-12-12 20:50:33 UTC

plugin loader: Fix converting gio errors in async _finish() functions

Author: Kalev Lember
Author Date: 2017-12-07 10:38:01 UTC

packagekit: Implement repository enabling

This fixes enabling repositories after clicking 'Enable' in the Enable
Proprietary Software Sources notification which up until now was
untested and just errored out.

Author: Mingye Wang
Author Date: 2017-10-21 13:44:23 UTC

Update zh_CN translation

Author: Mingye Wang
Author Date: 2017-10-21 13:43:46 UTC

Update zh_CN translation

Author: Joaquim Rocha
Author Date: 2017-10-17 10:58:30 UTC

Go to the overview mode by default before activation

The overview mode is the default one but was only being set when the
user opens GNOME Software (even if it was already running). This patch
sets that mode right after the loading is finished on start up, as a
consequence, the start up is a bit slower, but the user sees the
overview right away which makes it looks faster.

Author: Joaquim Rocha
Author Date: 2017-08-29 15:48:30 UTC

Do not show the sort button on add-ons (except in shell-extensions)

This is due to the fact that add-ons (except shell-extensions) cannot
be rated at the moment.

Author: Timm Bäder
Author Date: 2017-06-14 10:17:24 UTC

Rough gtk4 port

Author: Joaquim Rocha
Author Date: 2017-06-30 23:33:00 UTC

flatpak: Set the correct origin when installing a flatpakref

When installing a flatpakref, part of the process is to install its
ref file, and the code was assuming that this installation always
results in a new remote (named as app_name-origin). However, if there
is already a remote with the same URI as the one coming from the ref
file, it will not add the new one in order to avoid redudancy.

Since the GsApp representing the one in the flatpakref was being
assigned the "app_name-origin" as its origin, it would fail to install
later because this expected origin may not exist (as explained above).

To fix this, once the ref file is installed, we get the resulting
remote's name (i.e. a new one or the existing one) and override the
app's origin with it, which will allow the installation to succeed.

Author: Kalev Lember
Author Date: 2017-05-29 11:02:26 UTC

update dialog: Add separate sections for package additions and removals

... as per the design guidance in
https://github.com/gnome-design-team/gnome-mockups-software/blob/master/wireframes/atomic-updates.png

Author: Joaquim Rocha
Author Date: 2017-04-13 15:13:21 UTC

Add self tests for the core plugin

The tests cover currently gs_appstream_create_app.

Author: Robert Ancell
Author Date: 2016-11-07 03:55:18 UTC

Download changelog information on demand - this stops the UI blocking on startup

Author: Kalev Lember
Author Date: 2016-07-12 17:13:50 UTC

Show a better error message when downloading a distro upgrade fails

This is a backport of commits e07c324 and 0c271ef together with
translation updates.

Author: Richard Hughes
Author Date: 2016-10-31 09:08:58 UTC

Add a plugin to disable updates when running on a Fedora LiveUSB image

Author: Cédric VALMARY (Tot en òc)
Author Date: 2016-09-24 19:52:13 UTC

Updated Occitan translation

Author: Richard Hughes
Author Date: 2016-01-07 11:37:35 UTC

Allow filtering the search results by free software

Author: Pedro Albuquerque
Author Date: 2015-10-24 09:21:49 UTC

Updated Portuguese translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2015-05-23 20:04:13 UTC

Added Occitan translation