GNOME Music

gnome-music:wip/jfelder/searchbar-child

  1. Git
  2. lp:gnome-music
  3. wip/jfelder/searchbar-child
Last commit made on 2018-11-16
Get this branch:
git clone -b wip/jfelder/searchbar-child https://git.launchpad.net/gnome-music

Branch merges

Branch information

Name:
wip/jfelder/searchbar-child
Repository:
lp:gnome-music

Recent commits

48c6bc3... by Jean Felder <email address hidden>

CI: Remove window.py from flake8 exceptions

ff6465f... by Jean Felder <email address hidden>

window: Fix warnings with new Flake8

This is a follow up of commit c855efb4.

4565d98... by Jean Felder <email address hidden>

window: Search shortcut does not disable search-mode

Pressing on the search shortcut when the searchbar is already active
should not disable search mode.

15a26dd... by Jean Felder <email address hidden>

headerbar: Remove search state

SEARCH state referred to the child state of the search mode. With the
introduction of search_mode_allowed in the previous commit, Hearderbar
CHILD state can directly be used when the search mode is in child
state.

9deaf40... by Jean Felder <email address hidden>

window: Introduce search_mode_allowed property

Search mode cannot be changed if the search is in CHILD state.

c70cf7c... by Jean Felder <email address hidden>

window: Listen to search-state changes

Do not expose search_button from HeaderBar in Window.

a94dd6c... by Jean Felder <email address hidden>

searchbar: Directly use search_mode_enabled property

Remove reveal and toggle methods.
The whole logic can be simplified by directly using
search_mode_enabled property in Window and listening to its changes
in SearchBar.

f2ce2ea... by Jean Felder <email address hidden>

search: Introduce child state

Child state from search mode is enabled when clicking on an album or
artist result.
This prevents to expose Searchbar handling in SearchView.

10761ff... by Jean Felder <email address hidden>

window: Fix disable selection-mode on search

Always disable selection-mode when entering or leaving search mode.

ac1c0bb... by Jean Felder <email address hidden>

window: Remove unnecessary searchbar reveal call

When a child view is visible in search mode, searchbar is not
visible. Thus, it is unecessary to hide it when switching back to the
main view.