lp:gnome-music

Author: Alexandre Franke
Author Date: 2024-04-05 16:35:22 UTC

CONTRIBUTING: update link

Author: Fabio Tomat
Author Date: 2024-04-18 08:57:13 UTC

Update Friulian translation

Author: Michael Catanzaro
Author Date: 2024-04-03 23:43:20 UTC

Fix first character dropped when searching for anything

There is probably a smarter or more elegant way to do this, but this
works.

Fixes #553

Author: Marinus Schraal
Author Date: 2024-03-18 16:12:16 UTC

Release 44.1

Author: Sophie Herold
Author Date: 2024-02-29 21:06:40 UTC

metainfo: Fix wrong developer id

Appstream decided to use reversed domains. Please merge before 46 if possible.

Author: Andi Chandler
Author Date: 2024-02-21 20:14:15 UTC

Update British English translation

Author: Marinus Schraal
Author Date: 2024-02-13 10:13:01 UTC

flatpak: Remove GOA related talk names

An oversight from the GOA purge.

Author: Marinus Schraal
Author Date: 2024-02-11 11:21:16 UTC

meson: Fix two warnings

* run_command check defaulting to false, changing in the future
* version not set for local_config

Author: Marinus Schraal
Author Date: 2024-02-11 21:01:08 UTC

data/style: Remove SongsView styling

Oversight of the SongsView removal.

Author: Marinus Schraal
Author Date: 2024-02-11 20:38:46 UTC

po: Fix PreferencesDialog typo

Kindly brought up by Piotr Drąg.

Author: Carlos Garnacho
Author Date: 2024-02-06 15:57:27 UTC

grltrackerplaylists: Improve performance of "Recently Played" query

As the query goes, we query all songs played after a fixed date, merge
it tracker-miner-fs-3 data, then pick the 50 most recent ones. Take
the filter on the lastPlayed date outside of the larger query, so it
only applies to the 50 most recent songs returned.

This happened to be the main bottleneck on the query, since
nie:contentAccessed is not an indexed property, and this check would
run for all songs that were ever played, before ordering the results
and limiting to 50 elements.

Author: Carlos Garnacho
Author Date: 2024-02-06 15:57:27 UTC

grltrackerplaylists: Improve performance of "Recently Played" query

As the query goes, we query all songs played after a fixed date, merge
it tracker-miner-fs-3 data, then pick the 50 most recent ones. Take
the filter on the lastPlayed date outside of the larger query, so it
only applies to the 50 most recent songs returned.

This happened to be the main bottleneck on the query, since
nie:contentAccessed is not an indexed property, and this check would
run for all songs that were ever played, before ordering the results
and limiting to 50 elements.

Author: Marinus Schraal
Author Date: 2024-02-11 09:14:43 UTC

songwidgetmenu: Add Open Location item

This is disabled, as it is not hooked up yet.

Author: Marinus Schraal
Author Date: 2023-07-29 20:16:58 UTC

texturecache: Remove duplicate art loader from async queue

Currently we always create a new MediaArtLoader, this messes up the
AsyncQueue as it assumes it can clean up the queue by matching on the
async object (the MediaArtLoader).

Add a specific remove queue function to help with this case.

Author: Marinus Schraal
Author Date: 2024-01-29 23:38:52 UTC

about: Port to AdwAboutDialog

* Use translator-credits for translators.
* Update website to apps.gnome.org from wiki.

Author: Jean Felder
Author Date: 2022-02-11 20:16:33 UTC

searchheaderbar: Ensure that the entry gets the first key press

Author: Marinus Schraal
Author Date: 2024-01-17 22:57:32 UTC

playlistdialog: Drop Gtk.Dialog and use Adwaita widgets

Related: #579

Author: Marinus Schraal
Author Date: 2024-01-23 13:08:23 UTC

Remove selected properties from coreobjects

Author: Marinus Schraal
Author Date: 2024-01-23 00:10:19 UTC

ui/SearchView: Hide albums and artists on init

While doing a quick initial search with no album and/or artist results,
the headers and flowbox would be visible and empty. This is because the
hiding is only triggered when their respective models update, which does
not happen with no results.

Make albums/artists invisible by default to not hit this problem.

Author: Marinus Schraal
Author Date: 2024-01-19 10:41:59 UTC

ui/AlbumCover{ListItem}.ui: Use a single line label

This could improve scrolling in gridview as the content is now fixed
height.

Related #580

Author: Marinus Schraal
Author Date: 2023-11-19 13:06:24 UTC

texturecache: Fix flake8 warning

Something changed within Flake8 to start triggering this warning.

Add a noqa for E226 in this case; it seems reasonable in general, but
not so much in this case and introducing another flake8 error if applied.

Author: Marinus Schraal
Author Date: 2024-01-21 21:34:42 UTC

coresong: Fix play count update

The play count of the Grl.Media got updated, but the CoreSong update
never got triggered. Resulting in the playcount effectively staying the
same.

Trigger an update for the CoreSong values to remedy this.

Fixes: #587

Author: Marinus Schraal
Author Date: 2024-01-21 21:40:10 UTC

trackerwrapper: Correct log message

Last played log message mentioned play count mistakenly.

Author: Marinus Schraal
Author Date: 2023-08-06 21:07:29 UTC

Use slots for core objects

Slots are more efficient and faster than regular attributes.

Author: Marinus Schraal
Author Date: 2023-07-06 07:19:57 UTC

Add simple shufflesorter

Author: Marinus Schraal
Author Date: 2023-07-06 07:19:57 UTC

Add simple shufflesorter

Author: Nart Tlisha
Author Date: 2023-01-06 10:58:40 UTC

Add Abkhazian translation

Author: Jean Felder
Author Date: 2021-12-03 15:36:40 UTC

application: Handle files opening

This allows to display a FilesView populated with the audio files
received from command line. In that event, the FilesView is displayed
instead of the AlbumsView.

Closes: https://gitlab.gnome.org/GNOME/gnome-music/-/issues/268

Author: Jean Felder
Author Date: 2021-10-02 07:43:36 UTC

mpris

Author: Marinus Schraal
Author Date: 2022-05-03 19:12:23 UTC

Rework Tracker album query

Do one large query per album instead of several.

Author: Marinus Schraal
Author Date: 2022-04-25 09:18:06 UTC

Release 41.1

Author: Marinus Schraal
Author Date: 2022-04-22 09:09:14 UTC

cancellation meh

Author: Marinus Schraal
Author Date: 2022-03-18 09:12:20 UTC

artstack: Set default icon on coreobject change

Make sure no old icon lingers before a new one can be loaded by showing
the placeholder icon.

Author: Jean Felder
Author Date: 2020-05-20 00:01:02 UTC

songeditordialog: Use a similarity score to sort the suggestions

Use the song_similarity score computed from the existing tags and the
results found online.

Author: Marinus Schraal
Author Date: 2022-02-15 21:41:36 UTC

Set navigation-sidebar styling on sidebars

Author: Marinus Schraal
Author Date: 2022-02-14 12:41:47 UTC

artistsview: Cleanup

Remove stack related code.

Author: Marinus Schraal
Author Date: 2022-02-09 15:41:30 UTC

emptyview: Fix-m-upper

Author: Marinus Schraal
Author Date: 2022-02-01 20:49:18 UTC

asyncqueue: Add a slow running task pool

Author: Marinus Schraal
Author Date: 2021-09-19 12:57:37 UTC

meh

Author: Marinus Schraal
Author Date: 2021-05-11 22:06:56 UTC

Bring PlayerToolbar styling in line with mockups

Author: Marinus Schraal
Author Date: 2021-08-19 23:02:08 UTC

storeart: Replace blocking MediaArt call

MediaArt.file_to_jpeg is a blocking call.

Replace it with async Gio + GdkPixbuf based calls, also removing the
need to use a temporary file.

Author: Marinus Schraal
Author Date: 2021-08-17 21:47:31 UTC

searchview: Add a ScrolledWindow for AlbumWidget

In 57138fad AlbumWidget dropped it's ScrolledWindow, but SearchView was
not yet adapted to this change.

Make it so.

Author: Marinus Schraal
Author Date: 2021-08-27 20:24:30 UTC

albumwidget: Hide year if not available

Author: Marinus Schraal
Author Date: 2021-08-21 23:44:00 UTC

css: Remove unused styles

* no-music-found-label was used by EmptyView before it switched to
libhandy (eefce42b1b)
* discsongsflowbox was removed during the core rewrite (e626a26ad0)

Author: Quentin PAGÈS
Author Date: 2021-08-12 21:11:15 UTC

Update Occitan translation

Author: Jean Felder
Author Date: 2020-11-11 20:18:50 UTC

playlistswidget: Display a special view for an empty playlist

When a playlist does not contain any song, the view seems broken: the
big empty space makes the feature appear ambiguous and the line at the
top also looks out of place (see #424).

This issue is fixed by replacing the default state by a new empty view
when a playlist is empty. This view contains the icon introduced in
the previous commit.

closes: #424

Author: Marinus Schraal
Author Date: 2021-04-25 15:11:29 UTC

albumwidget: Enable song activation

Author: Hugo Carvalho
Author Date: 2021-04-23 11:04:45 UTC

Update Portuguese translation

Author: Jean Felder
Author Date: 2021-03-26 14:53:12 UTC

Release 3.38.3

Author: Jean Felder
Author Date: 2020-02-21 20:41:45 UTC

Handle CoreDisc updates

CoreDiscs need to be updated in 3 cases:
1. a song is removed from an album
2. a song is added to an album
3. a song disc number changes

1. a song is removed from an album
This case is already partially handled. Indeed, the song is already
part of the initial list of songs. Therefore, when, the song is
removed from the list, the associated coredisc model gets
updated. However, if the coredisc becomes empty, it is not removed.
This issue is fixed by checking the album model when a CoreDisc
becomes empty ('GrlTrackerWrapper.check_album_disc_changes' is
called).

2. a song is added to an album
In that case, the song is not added to the album (and the
associated coredisc) if the model has already been loaded because the
filter func has not been updated.
This issue is fixed by adding a '_check_album_content_change' method
to GrlTrackerWrapper when a new song is added or changed. This
function checks that the album already exists and updates the album if
necessary ('check_album_disc_changes' is called).
A new CoreDisc may be created, but not CoreDisc will be removed.

3. a song disc number changes
It's almost the same case as the previous
one. '_check_album_content_change' method is also called. In that
case, a CoreDisc may be added and an other CoreDisc may be removed.

This change is based on an initial implementation by Marinus Schraal.

Author: Jean Felder
Author Date: 2020-03-01 13:22:35 UTC

grltrackerplaylists: Improve smart playlists updates

The existing update method removes the songs which are not part of the
playlist anymore and adds the new songs at the end of the model.

This behavior assumes that the position of an existing song does not
change on update. This is wrong for most of the smart playlists (for
example, the MostPlayed playlist).

This issue is fixed by removing the existing songs and adding the new
ones in one go by a splice call. If a song was already part of the
playlist, its state is preserved.

Author: Jean Felder
Author Date: 2018-09-10 06:17:55 UTC

playertoolbar: Add playback button

Add a button to display PlaybackPopover from PlayerToolbar.

Closes: #14

Author: Marinus Schraal
Author Date: 2020-07-29 12:36:07 UTC

coregrilo: Clean up plugin activation for Tracker

The Tracker plugin loading has proven to be problematic over time, due
to how the plugin behaves and it interacts with Grilo and Music code,
see d7425fabf6 and 11f796999c for reference. This has resulted in
a difficult to comprehend loading procedure which needs background
knowledge to make sense.

Rework CoreGrilo plugin loading and activation to be different steps and
only activate the Tracker plugin when TrackerWrapper becomes available.

Author: Sam Thursfield
Author Date: 2020-06-29 22:38:57 UTC

Bundle Tracker 3 in the Flatpak for systems which don't have it

This commit allows the tracker3 version of GNOME Music to run on systems
which don't have a suitable version of Tracker in the base OS. It does
this by running tracker-miner-fs-3 inside the Flatpak sandbox. This will
lead to increased resource consumption as it'll duplicate the work of
any indexer in the host OS, but it's better than a broken app.

Author: Marinus Schraal
Author Date: 2020-06-26 14:44:03 UTC

data/ui: Remove has-focus property form PlaylistControls

Author: Jean Felder
Author Date: 2020-05-30 21:41:19 UTC

Release 3.34.6

Author: Jean Felder
Author Date: 2020-05-29 19:46:14 UTC

gstplayer: Disable gapless for non local files

Author: Jean Felder
Author Date: 2020-05-26 23:10:40 UTC

gstplayer: Handle buffering

When percent is smaller than 100, the pipeline is buffering. In that
case, the pipeline needs to be in the PAUSED state. Once the buffering
is complete, the pipeline can switch to the PLAYING state.

See
https://gstreamer.freedesktop.org/documentation/application-development/advanced/buffering.html

Closes: #350

Author: Sumaid Syed
Author Date: 2019-08-04 17:57:18 UTC

songsview: Add renderer for title and artist

Add renderers for title and artist so that even if
title or title tags are modified in the tag editor
they will updated in songsview.

https://gitlab.gnome.org/GNOME/gnome-music/issues/293

Author: Marinus Schraal
Author Date: 2020-02-17 11:48:04 UTC

debug spew

Author: Marinus Schraal
Author Date: 2020-03-02 16:36:55 UTC

coregrilo: Remove get_album_art_for_item

Author: Marinus Schraal
Author Date: 2020-03-02 14:11:11 UTC

grltrackerplaylists: Reuse default sorter

Author: Marinus Schraal
Author Date: 2020-02-16 20:01:45 UTC

albumwidget: Bind ListModel early

If we start listening to ListModel items-changed signals before binding
the model to the ListBox, it might not yet be synced and crash in the
signal callback. The callback assumes the ListBox widgets are already
created and this might result in a crash.

Bind the ListBox widget before connecting the signal handler.

Closes: #367

Author: Jean Felder
Author Date: 2020-01-18 21:17:36 UTC

playlistswidget: Rename to UserPlaylistWidget

This widget only deals with user playlists now.

Author: Marinus Schraal
Author Date: 2019-11-06 09:28:30 UTC

player: Flac+cue support

Author: Marinus Schraal
Author Date: 2019-11-22 16:01:13 UTC

grlacoustidwrapper: Use proper string formatting

Author: Marinus Schraal
Author Date: 2019-10-10 12:05:19 UTC

add/removals in Tracker smells

Author: Bilal Elmoussaoui
Author Date: 2019-09-17 09:24:33 UTC

Fix pep8 style issues

Author: Jean Felder
Author Date: 2019-09-12 11:00:43 UTC

flatpak: Build grilo-plugins from master

The patch to download artist art from theaudiodb source (used by
SearchView) has been merged.

Author: Marinus Schraal
Author Date: 2019-08-04 10:18:28 UTC

artistart: Access Grilo as property

Author: Jean Felder
Author Date: 2019-07-31 09:45:54 UTC

player: Ignore {next, previous} if the player is not playing

Next and previous song actions can be performed from a shortcut even if
the player has not started yet. This can result in a crash if the
player is in shuffle mode because it tries to access the
shuffle_indexes list which has not been populated yet.

Fix the issue by checking that the player is playing before performing
these actions.

Closes: #306

Author: Georges Basile Stavracas Neto
Author Date: 2019-07-17 15:51:50 UTC

discbox: Return a GtkListBoxRow

By returning a non-activatable, non-selectable row
we avoid the shadow in the first song of the disc.

Author: Bilal Elmoussaoui
Author Date: 2019-07-17 15:51:40 UTC

PlayListView: disable play action when the playlist is empty

Author: Bilal Elmoussaoui
Author Date: 2019-07-17 15:13:02 UTC

SongsView: don't clear the model

Author: Jean Felder
Author Date: 2019-07-15 21:54:48 UTC

ci: Remove grilo.py and query.py from flake8 exceptions

Those files do not exist anymore.

Author: Jean Felder
Author Date: 2018-08-20 22:59:11 UTC

tageditordialog: Initial songs support

Author: Jean Felder
Author Date: 2019-03-25 22:53:52 UTC

mpris: Synchronize metadata emission on song change

When a song changes, two signals are emitted: "current-song-changed"
and "thumbnail-updated". Most of the time, "current-song-changed" will
arrive first. So, the metadata property will be sent with an empty
artUrl. Then, the thumbnail_updated method will send again the
metadata with the correct artUrl. By adding a timeout, it waits for
the arrival of the second signal and prevents to send two different signals.

Related: #43, #101

Author: Marinus Schraal
Author Date: 2019-05-04 20:58:15 UTC

query: Indentation & Flake-8 cleanup

A lot of weird and inconsistent indentation choices were fixed, along with
flake8 fixes.

Remove query.py from flake8 exclusion.

Author: Aron Xu
Author Date: 2019-05-08 09:43:44 UTC

Update Chinese (China) translation

Author: Jean Felder
Author Date: 2018-07-31 22:49:21 UTC

musicbrainz: Add support to download coverarts

Initial musicbrainz support. It allows to download the cover art of an
album from its musicbrainz id.

It is based on grilo chromaprint, acoustid and musicbrainz
plugins. For every song, its chromaprint (a unique signature) is
computed. Then, this chromaprint is used to identify the song (title,
album, artist, etc) with the acoustid plugin. Finally, choose the
album with the most occurences and download its coverart from
https://coverartarchive.org/.

Author: Jean Felder
Author Date: 2018-05-29 18:28:17 UTC

albumwidget: Album art cover background

Display a blurred version of the album art cover as background. Labels
color are updated (black or white) to be visible with this new
background.

Closes: #10

Author: Sveinn í Felli
Author Date: 2019-02-22 16:48:33 UTC

Update Icelandic translation

Author: Jean Felder
Author Date: 2018-09-10 06:17:55 UTC

playertoolbar: Add playback button

Add a button to display PlaybackPopover from PlayerToolbar.

Closes: #14

Author: Jean Felder
Author Date: 2018-11-08 18:02:52 UTC

albumeditordialog: Initial cover support

AlbumEditorDialog adds the possibility to change the cover associated
with an album by selecting a new file.
This dialog can only be launched from the AlbumsView when
selection-mode is active.
Album name, artist, genre and year fields are also visible but they
are read only.

Author: Jean Felder
Author Date: 2018-12-19 15:22:12 UTC

starhandlerwidget: Do not activate in selection mode

When a view is in selection mode, clicking on a star should have no
effect.

Author: Jean Felder
Author Date: 2018-12-07 14:58:38 UTC

player: Change playlist_id property to a string

ALBUM album id (from grilo)
ARTIST artist name
PLAYLIST playlist id (from grilo)
SEARCH_RESULT empty string
SONGS empty string

Author: Jean Felder
Author Date: 2018-11-15 13:56:14 UTC

CI: Remove window.py from flake8 exceptions

Author: Marinus Schraal
Author Date: 2018-09-27 21:38:35 UTC

Triggered loading somewhat working.

Look away, I'm hideous.

Author: Marinus Schraal
Author Date: 2018-08-11 11:58:53 UTC

window: Key events

Author: Sveinn í Felli
Author Date: 2018-08-17 13:21:45 UTC

Update Icelandic translation

Author: Marinus Schraal
Author Date: 2018-08-15 13:47:50 UTC

searchbar: more to filterview

Author: Jean Felder
Author Date: 2018-07-08 00:50:50 UTC

grilo: Test musicbrainz plugins

This is not supposed to be a proper implementation (for tests
only). It is loosely based on a based from a patch from #6.
IT needs a change in grl-musicbrainz.lua from grilo-plugins line 53
"http://coverartarchive.org/release/%s/front" to
"http://coverartarchive.org/release-group/%s/front"

Author: Sam Thursfield
Author Date: 2018-07-10 13:03:14 UTC

Use a private Tracker domain

There are problems when using Tracker from a Flatpak because the version
on the host may be mismatched with the version inside the Flatpak. This
leads to issues such as
https://gitlab.gnome.org/GNOME/gnome-music/issues/175

To avoid this, Gnome Music can set up its own private Tracker domain.
This means that Gnome Music can ship all the Tracker services inside
its Flatpak bundle and use those, without touching the host for
anything.

This patch is incomplete, D-Bus service files need to be installed
for each Tracker service too corresponding to the
org.gnome.Music.Tracker.* names. It is also untested!!

Author: Jean Felder
Author Date: 2018-02-20 15:58:36 UTC

playlistview: Hide sidebar if there is no user playlist

Author: Marinus Schraal
Author Date: 2018-03-26 08:04:44 UTC

build: Using libsoup for scrobbling

Author: Marinus Schraal
Author Date: 2018-03-17 10:53:45 UTC

data: Remove domain from ui files

The ui files had the 'gnome-music' gettext domain name hard coded, while
after the move to Meson we use 'org.gnome.Music' instead.

Remove the domain, so the correct gettext domain gets picked up from the
environment.

Closes: #169

Author: Georges Basile Stavracas Neto
Author Date: 2018-03-06 22:04:08 UTC

albumartcache: Don't close non-existing stream on error

When a file fails to open, the stream variable is not assigned
and we jump to the exception handling code, which tries to close
the stream that hadn't even open.

This segfaults immediately.

Fix that by not trying to close the stream if it had an error.

Author: GNOME Translation Robot
Author Date: 2018-03-02 10:35:51 UTC

Update Scottish Gaelic translation

Author: Marinus Schraal
Author Date: 2018-02-27 21:36:05 UTC

grilo: Make metadata storage async

Author: Felipe Borges
Author Date: 2018-02-01 12:16:09 UTC

playbackpopover: Limit list length to 10 entries

As specified in the wireframes
https://github.com/gnome-design-team/gnome-mockups/blob/master/
music/wire-playback-buffer.png