Code review comment for lp:~gmb/maas/json-schema-part-1

Revision history for this message
Graham Binns (gmb) wrote :

On 10 February 2014 10:25, Gavin Panella <email address hidden> wrote:
> Couple of minor things:
>
> +def make_json_field(name, label, field_type=None, choices=None, default=None,
> + required=False):
>
> Dosnae matter much, but try using the following form for indentation:

Done. Is that the standard form for MAAS? I was doing it the LP way
but this looks better.

> + """Helper function for build a JSON power type parameters field."""

Actually should have been s/build/building/. Fixed.

« Back to merge proposal