Code review comment for lp:~gmb/maas/json-schema-part-1

Revision history for this message
Gavin Panella (allenap) wrote :

Looks grand :)

[1]

Couple of minor things:

+def make_json_field(name, label, field_type=None, choices=None, default=None,
+                    required=False):

Dosnae matter much, but try using the following form for indentation:

def make_json_field(
        name, label, field_type=None, choices=None, default=None,
        required=False):
    ... code here ...

+    """Helper function for build a JSON power type parameters field."""

s/for/to/

review: Approve

« Back to merge proposal