Code review comment for lp:~gmb/maas/generate-dns-for-dynamic-pool-bug-1382190

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good. I have a lot of comments, and there's a 255/256 issue in several places that needs your attention (I may be wrong), but +1 anyway. I'm happy to look again before landing if you want.

review: Approve

« Back to merge proposal