Code review comment for lp:~gmb/maas/enlist-mscm-to-RPC

On 11 September 2014 11:28, Gavin Panella <email address hidden> wrote:
>
>> +
>> +class EnlistNodesFromMSCM(amp.Command):
>> + """Probe for and enlist mscm machines attached to the cluster.
>> +
>> + :since 1.7:
>> + """
>> + arguments = [
>> + (b"host", amp.Unicode()),
>> + (b"username", amp.Unicode()),
>> + (b"password", amp.Unicode()),
>> + ]
>> + response = []
>> + errors = {}
>
> No errors at all?

probe_and_enlist_mscm() doesn't appear to raise any, so no. This is
one of those cases where we need a catch-all, because I don't know
what might happen further down the stack (this is the one and only
time I've ever been tempted to miss Java's error declarations…)