Merge lp:~gmb/launchpad/scars-of-ajax-dupefinding into lp:launchpad

[Graham Binns]

[Graham Binns (gmb)]

This branch enables the async dupesearch for packages and distros.

I've done this by:

 - Removing the use_async_dupefinder property from FileBugViewBase and
   the bugtarget-filebug-search template, since it's no longer needed.
 - Updating the JS in filebug-dupefinder.js to make sure that the onChange
   handler that calls reload_filebug_form() only gets called when the project
   field gets changed (without this change it gets called when the package
   field is changed, too, which makes no sense).

[Abel Deuring (adeuring)]

review: Approve (code)

=== modified file 'lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js'
--- lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-12-11 11:39:14 +0000
+++ lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-12-11 11:39:14 +0000
@@ -349,9 +349,11 @@
 
     // If there's a product field, hook it up to the
     // reload_filebug_form() function.
-    Y.on('change', function(e) {
-        reload_filebug_form();
-    }, Y.DOM.byId('field.product'));
+    var product_field = Y.one(Y.DOM.byId('field.product'));
+    if (Y.Lang.isValue(product_field)) {
+        Y.log(product_field);
+        product_field.on('change', reload_filebug_form);
+    }
 
     // Update the label on the search button so that it no longer
     // says "Continue".
 
=== modified file 'lib/lp/bugs/browser/bugtarget.py'
--- lib/lp/bugs/browser/bugtarget.py	2009-12-11 11:39:14 +0000
+++ lib/lp/bugs/browser/bugtarget.py	2009-12-11 11:39:14 +0000
@@ -360,13 +360,6 @@
             if 'field.actions' in key] != [] or
             self.user.inTeam(bug_supervisor))
 
-    @property
-    def use_asynchronous_dupefinder(self):
-        """Return True if the asynchronous dupe finder can be used."""
-        return (
-            IProduct.providedBy(self.context) or
-            IProject.providedBy(self.context))
-
     def getPackageNameFieldCSSClass(self):
         """Return the CSS class for the packagename field."""
         if self.widget_errors.get("packagename"):
 
=== modified file 'lib/lp/bugs/templates/bugtarget-filebug-search.pt'
--- lib/lp/bugs/templates/bugtarget-filebug-search.pt	2009-12-11 11:39:14 +0000
+++ lib/lp/bugs/templates/bugtarget-filebug-search.pt	2009-12-11 11:39:14 +0000
@@ -14,14 +14,12 @@
             tal:define="lp_js string:${icingroot}/build"
             tal:attributes="src string:${lp_js}/bugs/filebug-dupefinder.js"></script>
 
-    <tal:dupe-finder-js condition="view/use_asynchronous_dupefinder">
-      <script type="text/javascript">
-          LPS.use(
-            'base', 'node', 'oop', 'event', 'bugs.dupe_finder', function(Y) {
-              Y.bugs.setup_dupe_finder();
-          });
-      </script>
-    </tal:dupe-finder-js>
+    <script type="text/javascript">
+        LPS.use(
+          'base', 'node', 'oop', 'event', 'bugs.dupe_finder', function(Y) {
+            Y.bugs.setup_dupe_finder();
+        });
+    </script>
   </metal:block>
 
   <div metal:fill-slot="heading">
@@ -116,7 +114,7 @@
     <div id="filebug-form-container" style="display: none;">
     </div>
 
-    <p style="display: none" tal:condition="view/use_asynchronous_dupefinder">
+    <p style="display: none">
       <a id="filebug-base-url"
           tal:attributes="href view/inline_filebug_base_url"></a>
       <a id="filebug-form-url"