Merge lp:~gmb/launchpad/mute-button-cleanup-bug-204980 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Leonard Richardson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12602 |
Proposed branch: | lp:~gmb/launchpad/mute-button-cleanup-bug-204980 |
Merge into: | lp:launchpad |
Diff against target: |
261 lines (+117/-28) 5 files modified
lib/lp/bugs/browser/bug.py (+9/-0) lib/lp/bugs/browser/bugsubscription.py (+3/-0) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+28/-0) lib/lp/bugs/javascript/bugtask_index_portlets.js (+70/-17) lib/lp/bugs/templates/bug-portlet-subscribers.pt (+7/-11) |
To merge this branch: | bzr merge lp:~gmb/launchpad/mute-button-cleanup-bug-204980 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonard Richardson (community) | Approve | ||
Review via email: mp+53401@code.launchpad.net |
Commit message
[r=leonardr][bug=204980] A mute button has been added to all bug pages for members of the Malone Alpha team.
Description of the change
This branch does a bunch of clean-up work for the bug mail mute button
story and activates the mute link for malone-alpha members.
The main aim of this branch was to make the mute button behave sensibly
and to not have other parts of the UI doing things which could confuse
the user. To this end, I've made the following tweaks:
- Muted users no longer appear in the subscriber list
- The subscribe link doesn't change when a user is muted; it will now
always display "Subscribe me" for muted subscriptions.
I've made the following changes:
== lib/lp/
- I've added a current_
rendering the subscribers portlet so that the JavaScript can pick up
the user's mute status based on the CSS class of the Mute link's
parent (this might not be the most elegant way to do things but it's
consistent with how the Subscribe link works and I can't think of a
better way ATM).
== lib/lp/
- I've updated the BugPortletSubsc
sorted_
subscriptions.
== lib/lp/
- I've added a test case to cover the change to
BugPortletSu
== lib/lp/
- I've refactored the existing JS and added code to make the Mute link
behave as it should. It also now updates the Subscribe link properly.
== lib/lp/
- I've enabled the mute link for malone-alpha users via the
malone.