Merge lp:~gmb/launchpad/fix-opera-spacing-bug-401130 into lp:launchpad/db-devel

[Graham Binns]

[Graham Binns (gmb)]

A fix for a spacing issue with duplicate collapsibles in Opera.

[Gavin Panella (allenap)]

review: Approve (js)

=== modified file 'lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js'
--- lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-07-17 00:26:05 +0000
+++ lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js	2009-07-22 16:42:10 +0000
@@ -193,11 +193,6 @@
 
         if (bug_already_reported_expanders !== null &&
             bug_already_reported_expanders !== undefined) {
-            // Collapse all the details divs, since we don't want them
-            // expanded first up.
-            Y.each(Y.all('div.duplicate-details'), function(div) {
-                collapse_bug_details(div);
-            });
 
             // Set up the onclick handlers for the expanders.
             Y.each(Y.all('.similar-bug'), function(row) {
@@ -206,6 +201,18 @@
                 var bug_title_link = row.query('.duplicate-bug-link');
                 var view_bug_link = row.query('.view-bug-link');
 
+                // Grab the initial height of the element and create a
+                // config for the slide_out animation. This allows us to
+                // deal with browsers like Opera in which the JS engine
+                // takes a punt at the right height for the slid-out
+                // drawer and gets it completely and utterly wrong.
+                var initial_height = bug_details_div.get('scrollHeight');
+                var slide_out_config = {
+                    to: {
+                        height: initial_height
+                    }
+                };
+
                 // Shut down the default action for the link and mark it
                 // as a JS'd link. We do this as it's simpler than
                 // trying to find all the bits of the row that we want
@@ -233,7 +240,8 @@
                 // tabbing will expand the different bugs.
                 bug_title_link.on('focus', function(e) {
                     if (!bug_details_div.hasClass('lazr-opened')) {
-                        var anim = Y.lazr.effects.slide_out(bug_details_div);
+                        var anim = Y.lazr.effects.slide_out(
+                            bug_details_div, slide_out_config);
                         anim.run();
 
                         image.set(SRC, EXPANDER_EXPANDED);
@@ -249,7 +257,8 @@
                     if (bug_details_div.hasClass('lazr-opened')) {
                         collapse_bug_details(image);
                     } else {
-                        var anim = Y.lazr.effects.slide_out(bug_details_div);
+                        var anim = Y.lazr.effects.slide_out(
+                            bug_details_div, slide_out_config);
                         anim.run();
 
                         image.set(SRC, EXPANDER_EXPANDED);
@@ -264,6 +273,13 @@
 
             // Hide the bug reporting form.
             bug_reporting_form.setStyle(DISPLAY, NONE);
+
+            // Collapse all the details divs, since we don't want them
+            // expanded first up.
+            Y.each(Y.all('div.duplicate-details'), function(div) {
+                collapse_bug_details(div);
+            });
+
         }
 
         bug_not_reported_button = Y.get('#bug-not-already-reported');