Code review comment for lp:~gmb/launchpad/dont-leak-privacy-in-notifications-bug-373683

Revision history for this message
Leonard Richardson (leonardr) wrote :

r=me with some minor changes.

Did you mean to merge this with devel rather than db-devel? I make that mistake all the time.

Rather than bikeshedding the logic of the message generator, I suggest you just define four constants so you don't write the same string multiple times.

75 # extra notificationse by mistake.
118 # extra notificationse by mistake.
(Should be 'notifications')

review: Approve (code)

« Back to merge proposal