Code review comment for lp:~gmb/launchpad/bugzilla-3.4-sync-statuses-bug-415774

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Graham,

again, no complaints except a trailing space ;)

r=me
Abel

> === modified file 'lib/lp/bugs/doc/externalbugtracker-bugzilla-lp-plugin.txt'
> --- lib/lp/bugs/doc/externalbugtracker-bugzilla-lp-plugin.txt 2009-08-21 09:32:57 +0000
> +++ lib/lp/bugs/doc/externalbugtracker-bugzilla-lp-plugin.txt 2009-08-21 10:42:55 +0000
> @@ -301,34 +301,10 @@
> Getting remote statuses
> -----------------------
>
> -BugzillaLPPlugin.getRemoteStatus() will return the remote status of a
> -given bug as a string. If the bug has a resolution, that will be
> -returned too.
> -
> - >>> print bugzilla.getRemoteStatus(1)
> - RESOLVED FIXED
> -
> - >>> print bugzilla.getRemoteStatus(2)
> - NEW
> -
> -If a bug can't be found a BugNotFound error will be raised.
> -
> - >>> bugzilla.getRemoteStatus('no-such-bug')
> - Traceback (most recent call last):
> - ...
> - BugNotFound: no-such-bug
> -
> -If the data we've imported from Bugzilla is incomplete and doesn't
> -contain either the bug's status or its resolution an UnparseableBugData
> -error will be raised. We can add a sample bug to demonstrate this.
> -
> - >>> bugzilla._bugs[999] = {}
> - >>> bugzilla.getRemoteStatus(999)
> - Traceback (most recent call last):
> - ...
> - UnparseableBugData
> -
> - >>> del bugzilla._bugs[999]
> +BugzillaLPPlugin doesn't have any special functionality for getting
> +remote statuses. See the "Getting remote statuses" section of

The line above has the trailing space.

> +externalbugtracker-bugzilla-api.txt for details of getting remote
> +statuses from Bugzilla APIs.

review: Approve (code)

« Back to merge proposal