Merge lp:~glen666/chromium-browser/head.daily into lp:chromium-browser

Proposed by Elan Ruusamäe
Status: Needs review
Proposed branch: lp:~glen666/chromium-browser/head.daily
Merge into: lp:chromium-browser
Diff against target: 67 lines (+12/-2)
2 files modified
debian/changelog (+2/-2)
debian/rules (+10/-0)
To merge this branch: bzr merge lp:~glen666/chromium-browser/head.daily
Reviewer Review Type Date Requested Status
Micah Gersten (community) Disapprove
Review via email: mp+81369@code.launchpad.net

Description of the change

here some fixes for creating tarballs:

- bugfix for disabling launchpad translations
- allow .xz source internally

To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote :

Thank you for your interest in Chromium.
We won't take the xz src fix until Lucid is EOL since xz-utils only became part of the minimal task in Maverick. Also, we want the translations in the source file, but not necessarily applied in the build. This is due to launchpad only liking a single original tarball per version. In the future, please propose merges based on lp:chromium-browser. Feel free to ask in #ubuntu-mozillateam on freenode IRC or reply here with any questions.

review: Disapprove
Revision history for this message
Elan Ruusamäe (glen666) wrote :

i used this code branch to make source tarballs after they were stopped for some period

the options that got added default to OFF, so they should be fine to merge? or you don't accept anything that is outside Ubuntu?

Unmerged revisions

876. By Elan Ruusamäe

- add WANT_XZ_SRC, make WANT_LP_TRANSLATIONS work properly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-10-20 22:51:47 +0000
+++ debian/changelog 2011-11-05 18:25:26 +0000
@@ -1,4 +1,4 @@
1chromium-browser (15.0.870.0~svn20110903r99510-0ubuntu1) UNRELEASED; urgency=low1chromium-browser (17.0.930.0~svn20111105r108777-0ubuntu1) UNRELEASED; urgency=low
22
3 [ Fabien Tassin <fta@ubuntu.com> ]3 [ Fabien Tassin <fta@ubuntu.com> ]
4 * Disable NaCl until we figure out what to do with the private toolchain4 * Disable NaCl until we figure out what to do with the private toolchain
@@ -33,7 +33,7 @@
33 - update debian/rules33 - update debian/rules
34 - update debian/cdbs/tarball.mk34 - update debian/cdbs/tarball.mk
3535
36 -- Chris Coulson <chris.coulson@canonical.com> Thu, 20 Oct 2011 23:51:34 +010036 -- Chris Coulson <chrisbot@chinstrap> Sat, 05 Nov 2011 06:00:08 +0000
3737
38chromium-browser (13.0.782.215~r97094-0ubuntu1) oneiric; urgency=high38chromium-browser (13.0.782.215~r97094-0ubuntu1) oneiric; urgency=high
3939
4040
=== modified file 'debian/rules'
--- debian/rules 2011-10-20 22:49:22 +0000
+++ debian/rules 2011-11-05 18:25:26 +0000
@@ -20,6 +20,7 @@
20# Whitelist LP provided new langs only in release builds, PPAs ship them all20# Whitelist LP provided new langs only in release builds, PPAs ship them all
21WANT_ONLY_WHITELISTED_NEW_LANGS ?= 021WANT_ONLY_WHITELISTED_NEW_LANGS ?= 0
2222
23WANT_XZ_SRC ?= 0
23WANT_LZMA_SRC ?= 124WANT_LZMA_SRC ?= 1
24WANT_LZMA_DEBS ?= 125WANT_LZMA_DEBS ?= 1
25WANT_DEBUG := 026WANT_DEBUG := 0
@@ -153,6 +154,12 @@
153GYP_DEFINES += werror=$(NULL)154GYP_DEFINES += werror=$(NULL)
154endif155endif
155156
157ifeq (1,$(WANT_XZ_SRC))
158TAR_EXT := xz
159TAR_FLAGS := --xz
160COMPRESS := xz
161DEB_TARBALL = $(wildcard *.tar.bz2 *.tar.$(TAR_EXT))
162else
156ifeq (1,$(WANT_LZMA_SRC))163ifeq (1,$(WANT_LZMA_SRC))
157TAR_EXT := lzma164TAR_EXT := lzma
158TAR_FLAGS := --lzma165TAR_FLAGS := --lzma
@@ -163,6 +170,7 @@
163TAR_FLAGS := -j170TAR_FLAGS := -j
164COMPRESS := bzip2171COMPRESS := bzip2
165endif172endif
173endif
166174
167post-patches::175post-patches::
168 perl $(CURDIR)/debian/enable-dist-patches.pl $(DEBIAN_DIST_VERSION) $(CURDIR)/debian/patches/series176 perl $(CURDIR)/debian/enable-dist-patches.pl $(DEBIAN_DIST_VERSION) $(CURDIR)/debian/patches/series
@@ -710,6 +718,7 @@
710endif718endif
711endif719endif
712gos-pack:720gos-pack:
721ifeq (1,$(WANT_LP_TRANSLATIONS))
713ifneq (,$(findstring Ubuntu,$(DEBIAN_DIST)))722ifneq (,$(findstring Ubuntu,$(DEBIAN_DIST)))
714 # Merge Translations from Launchpad723 # Merge Translations from Launchpad
715 bzr export $(TMP_DIR)/translations-tools $(TRANSLATIONS_TOOLS_BRANCH)724 bzr export $(TMP_DIR)/translations-tools $(TRANSLATIONS_TOOLS_BRANCH)
@@ -718,6 +727,7 @@
718 # Patches created:727 # Patches created:
719 @( cd $(TMP_DIR)/src ; find translations-patches -type f | xargs --verbose -n 1 diffstat -p 1 )728 @( cd $(TMP_DIR)/src ; find translations-patches -type f | xargs --verbose -n 1 diffstat -p 1 )
720endif729endif
730endif
721 # Pack731 # Pack
722 if [ src != $(DEB_TAR_SRCDIR) ] ; then mv $(TMP_DIR)/src $(TMP_DIR)/$(DEB_TAR_SRCDIR) ; fi732 if [ src != $(DEB_TAR_SRCDIR) ] ; then mv $(TMP_DIR)/src $(TMP_DIR)/$(DEB_TAR_SRCDIR) ; fi
723 mv $(TMP_DIR)/tools/depot_tools $(TMP_DIR)/$(DEB_TAR_SRCDIR)/depot_tools733 mv $(TMP_DIR)/tools/depot_tools $(TMP_DIR)/$(DEB_TAR_SRCDIR)/depot_tools

Subscribers

People subscribed via source and target branches

to status/vote changes: