Code review comment for lp:~gl-az/percona-xtrabackup/BT23557-2.1-lp1160788

Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

1) Misprint in 477: "oarallel" instead of "parallel";

2) "DECRYPTING AND/OR DECOMPRESSING" in 524;

3) I have not found checking $option_parallel on positive value.

'parallel=i' => \$option_parallel,

It is supposed $option_parallel is integer. In the case if $option_parallel is less then 0 decrypt_decompress() will not work correctly. It seems there will be infinite loop in:

while ($freepidindex >= $option_parallel)

It should be checked somewhere.

review: Needs Fixing (g2)

« Back to merge proposal