Code review comment for lp:~gl-az/percona-server/ST-41544-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - This now looks good, thanks for explaining the
      rpl_mixed_drop_create_temp_table bits. But there are a couple of
      bzr bits that need addressing. As for the patch maintenance, it
      looks like the hard part is already behind us, at least until
      upstream fixes the same.

    - Please recommit with --file option instead of -m ;)

    - The old rpl_drop_temp.result should be bzr mv'ed to
      rpl_stm_drop_temp.result? Likewise rpl_rewrt_db.result to
      rpl_stm_rewrt_db.result? While at that, the small -slave.opt
      files too? All this would help with bzr merges.

review: Needs Fixing

« Back to merge proposal