Code review comment for lp:~gl-az/percona-server/ST-41544-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> > - rpl_stop_slave tests more than temp table replication. Possible
> > to restore it for MBR?
>
> Not easily, the test is really designed for STMT only as it does diff_tables
> between the master and slave, mostly on temp tables. Since this change makes
> temp tables operate more like ROW when doing MIXED it means we would almost
> have to rewrite a new stop_slave test for MBR that just skipped anything
> related to temp tables in order to test the non-temp bits. If you think we
> should go that far then yeah, I can do that.

Are you referring to "bug 56118" part of rpl_stop_slave? There is "bug 58546" part too, which does not seem to be related to temp tables. Maybe split the testcase then?

« Back to merge proposal