Merge lp:~gl-az/percona-server/5.5-1018264 into lp:percona-server/5.5

Proposed by George Ormond Lorch III
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 309
Proposed branch: lp:~gl-az/percona-server/5.5-1018264
Merge into: lp:percona-server/5.5
Diff against target: 19 lines (+9/-0)
1 file modified
Percona-Server/storage/innobase/btr/btr0sea.c (+9/-0)
To merge this branch: bzr merge lp:~gl-az/percona-server/5.5-1018264
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Review via email: mp+126843@code.launchpad.net

Commit message

Fix for PS bug lp:1018264 - Multiple hash index partitions causes overly
large hash index: When multiple adaptive hash index partitions are
specified, _each_ partition was being created with hash_size which should
be 1/64 of the total size of all buffer pools which is incorrect and can
cause overly high memory usage. hash_size should be representing the
_total_ size of all partitions, not the individual size of each partition.
Modfied code to divide hash_size in btr_search_sys_create by number of
partitions (btr_search_index_num).

Description of the change

Fix for PS bug lp:1018264 - Multiple hash index partitions causes overly
large hash index: When multiple adaptive hash index partitions are
specified, _each_ partition was being created with hash_size which should
be 1/64 of the total size of all buffer pools which is incorrect and can
cause overly high memory usage. hash_size should be representing the
_total_ size of all partitions, not the individual size of each partition.
Modfied code to divide hash_size in btr_search_sys_create by number of
partitions (btr_search_index_num).

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/521/

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Percona-Server/storage/innobase/btr/btr0sea.c'
--- Percona-Server/storage/innobase/btr/btr0sea.c 2012-05-10 07:49:14 +0000
+++ Percona-Server/storage/innobase/btr/btr0sea.c 2012-09-28 02:18:22 +0000
@@ -183,6 +183,15 @@
183 //rw_lock_create(btr_search_latch_key, &btr_search_latch,183 //rw_lock_create(btr_search_latch_key, &btr_search_latch,
184 // SYNC_SEARCH_SYS);184 // SYNC_SEARCH_SYS);
185185
186 /* PS bug lp:1018264 - Multiple hash index partitions causes overly
187 large hash index: When multiple adaptive hash index partitions are
188 specified, _each_ partition was being created with hash_size which
189 should be 1/64 of the total size of all buffer pools which is
190 incorrect and can cause overly high memory usage. hash_size
191 should be representing the _total_ size of all partitions, not the
192 individual size of each partition. */
193 hash_size /= btr_search_index_num;
194
186 btr_search_sys = mem_alloc(sizeof(btr_search_sys_t));195 btr_search_sys = mem_alloc(sizeof(btr_search_sys_t));
187196
188 /* btr_search_index_num should be <= 32. (bits of trx->has_search_latch) */197 /* btr_search_index_num should be <= 32. (bits of trx->has_search_latch) */

Subscribers

People subscribed via source and target branches