Code review comment for lp:~gkliska/openobject-addons/l10n_hr

Revision history for this message
Goran Kliska (gkliska) wrote :

Hi Olivier,

Thank you for fast response.

This Chart of Accounts is the most popular one in Croatia for SMBs.
In description I stated the source http://www.rrif.hr/dok/preuzimanje/rrif-rp2012.rar
We added some additional accounts according to recent law changes.
Don't worry.

- Removed l10n_hr/data/account.fiscal.position.template.csv.
We wanted to keep the data in csv because we can pass it to accountants who use spreadsheets.

- Removed the i18n/ sub-directory.
  I was tempted to include English translation of COA and dependency l10n_multilang, but it is better to keep it simple for start.

- l10n_hr/l10n_hr_chart_template.xml: using the "search=[domain]" ...
Fixed. In 6.0 time there was some issues with cache, I did'n restart the server after changing .csv/.xml files with data and old workaround stayed unnoticed.

Sorry for not being "no-brainer" :(.
Hope that

Thank you so much for review.

Goran Kliska

« Back to merge proposal