Merge lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin into lp:xubuntu-docs/quantal

Proposed by Giuseppe Terrasi
Status: Rejected
Rejected by: Pasi Lallinaho
Proposed branch: lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin
Merge into: lp:xubuntu-docs/quantal
Diff against target: 33 lines (+5/-4)
1 file modified
desktop-guide/libs/xubuntu-book.css (+5/-4)
To merge this branch: bzr merge lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin
Reviewer Review Type Date Requested Status
Pasi Lallinaho (community) Disapprove
Review via email: mp+128380@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Pasi Lallinaho (knome) wrote :

In what browser does this happen?

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

Hi
This is chromium browser.
Il giorno 07/ott/2012 16:39, "Pasi Lallinaho" <email address hidden> ha
scritto:

> In what browser does this happen?
> --
>
> https://code.launchpad.net/~giuseppeterrasi/xubuntu-docs/margin/+merge/128380
> You are the owner of lp:~giuseppeterrasi/xubuntu-docs/margin.
>

Revision history for this message
Pasi Lallinaho (knome) wrote :

After enabling this fix, does the documentation still look fine in Firefox, the default Xubuntu browser?

Revision history for this message
Pasi Lallinaho (knome) :
review: Abstain
Revision history for this message
Pasi Lallinaho (knome) wrote :

This has been fixed in the latest Raring branch.

Revision history for this message
Pasi Lallinaho (knome) wrote :

To be more exact, this has been fixed with a different solution, which works better for both FF and Chrome.

review: Disapprove

Unmerged revisions

13. By Giuseppe Terrasi

change margin div.caution, div.tip

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'desktop-guide/libs/xubuntu-book.css'
--- desktop-guide/libs/xubuntu-book.css 2012-09-18 00:31:15 +0000
+++ desktop-guide/libs/xubuntu-book.css 2012-10-07 11:24:23 +0000
@@ -185,7 +185,7 @@
185185
186 .chapter .toc dt {186 .chapter .toc dt {
187 margin-bottom: 0;187 margin-bottom: 0;
188 }188 }
189189
190 .toc dd dl dt {190 .toc dd dl dt {
191 margin-top: 0.2em;191 margin-top: 0.2em;
@@ -217,8 +217,9 @@
217div.note td > p,217div.note td > p,
218div.tip td > p,218div.tip td > p,
219div.warning td > p {219div.warning td > p {
220 margin-top: -32px;220 margin-top: -12px;
221 margin-bottom: 0;221 margin-bottom: 0;
222 padding-bottom: 16px;
222}223}
223224
224div.caution img,225div.caution img,
@@ -226,8 +227,8 @@
226div.note img,227div.note img,
227div.tip img,228div.tip img,
228div.warning img {229div.warning img {
229 margin-bottom: -32px;230 margin-bottom: -22px;
230 margin-right: 16px;231 margin-right: 12px;
231 padding-bottom: 16px;232 padding-bottom: 16px;
232}233}
233234

Subscribers

People subscribed via source and target branches