Merge lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin into lp:xubuntu-docs/quantal

Proposed by Giuseppe Terrasi
Status: Rejected
Rejected by: Pasi Lallinaho
Proposed branch: lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin
Merge into: lp:xubuntu-docs/quantal
Diff against target: 33 lines (+5/-4)
1 file modified
desktop-guide/libs/xubuntu-book.css (+5/-4)
To merge this branch: bzr merge lp:~giuseppeterrasi-deactivatedaccount/xubuntu-docs/margin
Reviewer Review Type Date Requested Status
Pasi Lallinaho (community) Disapprove
Review via email: mp+128380@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Pasi Lallinaho (knome) wrote :

In what browser does this happen?

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

Hi
This is chromium browser.
Il giorno 07/ott/2012 16:39, "Pasi Lallinaho" <email address hidden> ha
scritto:

> In what browser does this happen?
> --
>
> https://code.launchpad.net/~giuseppeterrasi/xubuntu-docs/margin/+merge/128380
> You are the owner of lp:~giuseppeterrasi/xubuntu-docs/margin.
>

Revision history for this message
Pasi Lallinaho (knome) wrote :

After enabling this fix, does the documentation still look fine in Firefox, the default Xubuntu browser?

Revision history for this message
Pasi Lallinaho (knome) :
review: Abstain
Revision history for this message
Pasi Lallinaho (knome) wrote :

This has been fixed in the latest Raring branch.

Revision history for this message
Pasi Lallinaho (knome) wrote :

To be more exact, this has been fixed with a different solution, which works better for both FF and Chrome.

review: Disapprove

Unmerged revisions

13. By Giuseppe Terrasi

change margin div.caution, div.tip

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktop-guide/libs/xubuntu-book.css'
2--- desktop-guide/libs/xubuntu-book.css 2012-09-18 00:31:15 +0000
3+++ desktop-guide/libs/xubuntu-book.css 2012-10-07 11:24:23 +0000
4@@ -185,7 +185,7 @@
5
6 .chapter .toc dt {
7 margin-bottom: 0;
8- }
9+ }
10
11 .toc dd dl dt {
12 margin-top: 0.2em;
13@@ -217,8 +217,9 @@
14 div.note td > p,
15 div.tip td > p,
16 div.warning td > p {
17- margin-top: -32px;
18+ margin-top: -12px;
19 margin-bottom: 0;
20+ padding-bottom: 16px;
21 }
22
23 div.caution img,
24@@ -226,8 +227,8 @@
25 div.note img,
26 div.tip img,
27 div.warning img {
28- margin-bottom: -32px;
29- margin-right: 16px;
30+ margin-bottom: -22px;
31+ margin-right: 12px;
32 padding-bottom: 16px;
33 }
34

Subscribers

People subscribed via source and target branches