Code review comment for lp:~gioele/bzr/forgot-commit-message
Revision history for this message
| Gioele Barabucci (gioele) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> So *I* would prefer if this would only warn and not actually prompt. A
> user can generally "bzr uncommit" if they have a problem.
People on the mailing list have pointed out that there could be problems with that approach.
For example Jelmer Vernooij commented
FWIW bzr-svn does support uncommit, the main issue would be
that Subversion still shows the original commit with the typo
when running "svn log" on the repository root.
> The main issue that comes to mind is that something like 'qcommit' will
> fail if you gave the commit the same message as a filename. As it will
> spawn commit under-the-covers which may block waiting for user input.
Doesn't qcommit provide a new ui_factory implementation that overrides the textual ui interface? A correctly implemented qbzr ui_factory should show you a graphical warning message with the same GUI used by qcommit. Or did I misunderstand the purpose of UIFactory?