Code review comment for lp:~gioele/bzr/forgot-commit-message

2009/11/19 John A Meinel <email address hidden>:
> Review: Abstain
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Gioele Barabucci wrote:
>> Gioele Barabucci has proposed merging lp:~gioele/bzr/forgot-commit-message into lp:bzr.
>>
>>     Requested reviews:
>>     bzr-core (bzr-core)
>> Related bugs:
>>   #73073 warn when commit -m argument is omitted
>>   https://bugs.launchpad.net/bugs/73073
>>
>>
>> This patch adds a check to the commit command to catch the common mistake of passing a file name instead of a commit message to the '-m' option.
>>
>
> So *I* would prefer if this would only warn and not actually prompt. A
> user can generally "bzr uncommit" if they have a problem.

I agree.

Also, can I suggest you please put both lines in one call to
ui_factory.warning, with a \n? For the current textui it makes no
difference, but if it was displayed in eg a dialog box it is obviously
just one logical warning.

--
Martin <http://launchpad.net/~mbp/>