> get_room_memberlist and is_room_owner should guarantee to return a Deferred,
> rather than returning None if bad args are given. Using defer.fail would make
> sense here.
Done.
>
> I think owner_result and parse_memberlist in the RoomOwner plugin should be
> inner funcs as they are just locally used callbacks (this would match the
> pattn used elsewhere in Enadroid, including further down in this diff).
k. Have basically reworked the methods here in the process:
* Made private
* Daisy changed better
* Split out to make a bit easier to read
> get_room_memberlist and is_room_owner should guarantee to return a Deferred,
> rather than returning None if bad args are given. Using defer.fail would make
> sense here.
Done.
>
> I think owner_result and parse_memberlist in the RoomOwner plugin should be
> inner funcs as they are just locally used callbacks (this would match the
> pattn used elsewhere in Enadroid, including further down in this diff).
k. Have basically reworked the methods here in the process:
* Made private
* Daisy changed better
* Split out to make a bit easier to read
Let me know if that works.