Code review comment for lp:~gingerchris/endroid/nonmemberkick

Revision history for this message
Martin Morrison (isoschiz) wrote :

The presence of an explicit fetch of the roomowner plugin's config in the core seems horrible. Can't we just move that config up to be core config? We can then move it back out to plugin config once we've cleaned up the interactions throughout.

Some of your docstrings don't have a newline after the opening triple quotes. Please change, as it is easier to read the other way.

« Back to merge proposal